From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21846 invoked by alias); 18 Oct 2016 14:55:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21828 invoked by uid 89); 18 Oct 2016 14:55:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:866, Hx-spam-relays-external:cmgw3, Hx-spam-relays-external:10.0.90.84, H*RU:10.0.90.84 X-HELO: gproxy5-pub.mail.unifiedlayer.com Received: from gproxy5-pub.mail.unifiedlayer.com (HELO gproxy5-pub.mail.unifiedlayer.com) (67.222.38.55) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Tue, 18 Oct 2016 14:55:19 +0000 Received: (qmail 12285 invoked by uid 0); 18 Oct 2016 14:55:18 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy5.mail.unifiedlayer.com with SMTP; 18 Oct 2016 14:55:18 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id x2v21t00S2f2jeq012v5yR; Tue, 18 Oct 2016 08:55:05 -0600 X-Authority-Analysis: v=2.1 cv=KLfJUj1o c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=20KFwNOVAAAA:8 a=CCpqsmhAAAAA:8 a=q3AIsKsCy15jYf_3RM8A:9 a=YrYChO74Fy4A:10 a=e_O65bzb51kRm2y5VmPK:22 a=ul9cdbp4aOFLsgKbc677:22 Received: from 174-16-143-211.hlrn.qwest.net ([174.16.143.211]:58542 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1bwUz0-00025H-EM; Tue, 18 Oct 2016 08:03:10 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 16/17] Convert dwarf_expr_context_funcs to methods References: <1476393012-29987-1-git-send-email-tom@tromey.com> <1476393012-29987-17-git-send-email-tom@tromey.com> <94f5892b-e4d2-f903-36e2-513e37f3947b@redhat.com> <878ttmid6e.fsf@tromey.com> <4e861038-bc8a-6667-9a11-6c37e7ed4489@redhat.com> Date: Tue, 18 Oct 2016 14:55:00 -0000 In-Reply-To: <4e861038-bc8a-6667-9a11-6c37e7ed4489@redhat.com> (Pedro Alves's message of "Tue, 18 Oct 2016 11:51:13 +0100") Message-ID: <87a8e13gbp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1bwUz0-00025H-EM X-Source-Sender: 174-16-143-211.hlrn.qwest.net (pokyo) [174.16.143.211]:58542 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00512.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: >> All I saw was the comment about possibly reducing churn: >> https://sourceware.org/ml/gdb-patches/2016-10/msg00208.html Pedro> I'm sorry, I had written comments about the parenthesis Pedro> thing and also about wondering whether these methods with Pedro> internal_error could be pure virtual ('= 0;') instead, and if not, Pedro> about adding a small comment mentioning it. I think the internal_error thing can't be a pure virtual because there are subclasses that do not implement this method. I could push the internal error into the subclasses though. Pedro> I sometimes write reviews of separate chunks in separate emails in Pedro> then merge it all before sending. Guess I deleted that email Pedro> by mistake. It's no problem. Tom