From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31756 invoked by alias); 6 Jan 2015 08:12:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31735 invoked by uid 89); 6 Jan 2015 08:12:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Jan 2015 08:12:50 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1Y8PFv-0002Be-1e from Yao_Qi@mentor.com ; Tue, 06 Jan 2015 00:12:47 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.224.2; Tue, 6 Jan 2015 00:12:45 -0800 From: Yao Qi To: Pedro Alves CC: Subject: Re: [PATCH 4/8] linux-nat.c: clean up pending status checking and resuming LWPs References: <1419625871-28848-1-git-send-email-palves@redhat.com> <1419625871-28848-5-git-send-email-palves@redhat.com> Date: Tue, 06 Jan 2015 08:12:00 -0000 In-Reply-To: <1419625871-28848-5-git-send-email-palves@redhat.com> (Pedro Alves's message of "Fri, 26 Dec 2014 20:31:07 +0000") Message-ID: <87a91wuy2p.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00068.txt.bz2 Pedro Alves writes: > Whenever we resume an LWP, we must clear a few flags and flush the > LWPs register cache. Instead of open coding that in many places, use > an helper function. After this patch, the behavior is changed to flush the LWP's register cache rather than register cache of all LWPs (registers_changed -> registers_changed_ptid (lp->ptid)), right? Although I believe the change is correct, we should mention it in the commit log. --=20 Yao (=E9=BD=90=E5=B0=A7)