From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25539 invoked by alias); 10 Oct 2014 16:38:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25430 invoked by uid 89); 10 Oct 2014 16:38:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 10 Oct 2014 16:38:42 +0000 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s9AGcbKh012379 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 10 Oct 2014 16:38:38 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s9AGcaLo007104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Oct 2014 16:38:37 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s9AGcZtm022345; Fri, 10 Oct 2014 16:38:35 GMT Received: from termi.oracle.com (/10.175.211.52) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 10 Oct 2014 09:38:34 -0700 From: jose.marchesi@oracle.com (Jose E. Marchesi) To: Sergio Durigan Junior Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/9] Move `compute_probe_arg' and `compile_probe_arg' to probe.c References: <1411724905-31234-1-git-send-email-jose.marchesi@oracle.com> <1411724905-31234-3-git-send-email-jose.marchesi@oracle.com> <87tx3q6km3.fsf@redhat.com> Date: Fri, 10 Oct 2014 16:38:00 -0000 In-Reply-To: <87tx3q6km3.fsf@redhat.com> (Sergio Durigan Junior's message of "Mon, 29 Sep 2014 20:02:44 -0400") Message-ID: <87a953ev8x.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00252.txt.bz2 > This patch moves the `compute_probe_arg' and `compile_probe_arg' functions > from stap-probe.c to probe.c. The rationale is that it is reasonable to > assume that all backends will provide the `$_probe_argN' convenience > variables, and that the user must be placed on the PC of the probe when > requesting that information. The value and type of the argument can still be > determined by the probe backend via the `pops->evaluate_probe_argument' and > `pops->compile_to_ax' handlers. > > Note that a test in gdb.base/stap-probe.exp had to be adjusted because the "No > SystemTap probe at PC" messages are now "No probe at PC". Hi Jose, Thanks for this patch. Just a nit on the ChangeLog entry. Fixed in the patch.