Re: [RFC] auto-generate most target debug methods

[Tom Tromey <tromey@redhat.com>]

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> What I'm not sure I like is the need for new typedefs.  Seems odd to
Pedro> me to have a textual mismatch between the declaration and all
Pedro> the implementations.

Yeah.

Pedro> Did you try an __attribute__(())-like approach?

I thought of it, but I didn't give it a try, I think just because the
whole idea was speculative enough that I didn't want to sink a lot of
time into it.

Pedro>      void (*to_resume) (struct target_ops *, ptid_t, int step,
Pedro> 		       enum gdb_signal)
Pedro>        TARGET_DEBUG_PRINT (step, print_target_resume_step)
Pedro>        TARGET_DEFAULT_NORETURN (noprocess ());

Syntactically I think I prefer the attributes next to the parameters;
though perhaps this other approach can be used to solve the
debug_print_register problem.

I'll go a bit deeper.

Tom