Re: [PATCH 7/7] [gdb/testsuite] Use unique portnum in parallel testing (check//% case)

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Fix this by:
Tom> - creating a common lockdir build/gdb/testsuite.lockdir for make target
Tom>   check//%,
Tom> - passing this down to the runtests invocations using variable GDB_LOCK_DIR,
Tom>   and
Tom> - using GDB_LOCK_DIR in lock_dir.

I think I've never once used check//.
I'm not even sure I was aware of its existence.

Tom>  proc lock_dir {} {
Tom> +    if { [info exists ::GDB_LOCK_DIR] } {
Tom> +	# When using check//.
Tom> +	return $::GDB_LOCK_DIR
Tom> +    }
Tom> +
Tom>      return [make_gdb_parallel_path cache]
Tom>  }

I guess this approach of not always requiring GDB_LOCK_DIR is handy when
running runtest by hand... I was thinking it might be better to unify
all the scenarios here, but really this doesn't seem so complicated.

Approved-By: Tom Tromey <tom@tromey.com>


Tom