From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 7B5E83849ACF for ; Fri, 19 Apr 2024 19:27:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B5E83849ACF Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7B5E83849ACF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713554859; cv=none; b=UE1zDjh2GbMACTXgGb01yuzZ9WPkkB7Wj9YIkovq6seV/KO2GKbb9yHSJaad/KZMtRR5+HZB5dl3/0sVrxvesXTm3oQQR+mK1vwx5hDOlqtmLOA6f5JG9oC9sBqWunMau/8+NLeS0Bab7MU0S1CverEQUq4VYfL3g55qVfXg0cc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713554859; c=relaxed/simple; bh=WKIw22TySaK3VMbcSAn9p1HNsCjPo+cgfCZa5qprlLY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XMYyMiGwFtNjmfkriHGK9RCaEZNQwoXoutjTbZ4O6jexcthVW3zT7UCSFL/LPlIIEEzZdGKoSjB9bM/QWyU9gHSi9Kua5EFcSJc2JZs7bW8i8uGaDnyYRZ4fKXO/NzNVe48/eMLGtR9Iq0FZn31XuKhs6W/BEj+blPyBecTDsuY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5002a.ext.cloudfilter.net ([10.0.29.215]) by cmsmtp with ESMTPS id xhsFrTHRutf2QxttZruYoY; Fri, 19 Apr 2024 19:27:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id xttYrQGLkr1IfxttZr0KYJ; Fri, 19 Apr 2024 19:27:37 +0000 X-Authority-Analysis: v=2.4 cv=BawT0at2 c=1 sm=1 tr=0 ts=6622c5a9 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=_ZhYKdCeAAAA:8 a=7d_E57ReAAAA:8 a=zstS-IiYAAAA:8 a=VLQDRybDP7vffW3rWRoA:9 a=vLSSZjyX2LUA:10 a=uqOk3ZSnBfCTOznnrPA1:22 a=jhqOcbufqs7Y1TYCrUUU:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=WKIw22TySaK3VMbcSAn9p1HNsCjPo+cgfCZa5qprlLY=; b=WS9IbNwrCrdKtS5QJopPk6GYsa 94e7WIF4Gom8OGAIXLf1/pPkGhMpQaPP71DPYoN+0XMJ/GnxETW8XZDVaREAPV7JYGpOGymauMOYi X8L8yHru6PHWVJtLeRWZp6ZTL; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:55992 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rxttY-003hpp-1H; Fri, 19 Apr 2024 13:27:36 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH 6/6] gdb: add target_debug_printf and target_debug_printf_nofunc References: <20240417205426.2030615-1-simon.marchi@polymtl.ca> <20240417205426.2030615-6-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 19 Apr 2024 13:27:35 -0600 In-Reply-To: <20240417205426.2030615-6-simon.marchi@polymtl.ca> (Simon Marchi's message of "Wed, 17 Apr 2024 16:54:11 -0400") Message-ID: <87bk65up94.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1rxttY-003hpp-1H X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:55992 X-Source-Auth: tom+tromey.com X-Email-Count: 17 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDWMBqcVVN1bVqNgQwrRsJ1nAoxipv6D3No5O8BA0gUx5/sVgLQ8FPKz/ziAOT+gFnPSORUF6FzPUbzPDL00q+Pd+qy4fctbCTyBZ2dMErKnv0nSiZxR 5O4FbV3HeHju4RXviFpwzJVVfi2nLIgVFb9PriQ/GhSxYobT8mawIVEye6U2Xi7WAmlkT+srcGQbGOE3OzwQcgLEq2s4haaxolA= X-Spam-Status: No, score=-3015.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> From: Simon Marchi Simon> Add the `target_debug_printf` and `target_debug_printf_nofunc` macros Simon> and use them when outputting debug messages depending on `targetdebug`. Simon> I opted for `target_debug_printf_nofunc` to follow the current style Simon> where the function name is already printed, along with the arguments. Simon> Modify the debug printfs in the `debug_target` methods (generated by Simon> `make-target-delegates.py`) to use `target_debug_printf_nofunc` as well. Simon> This makes the "target" debug prints integrate nicely with the other Simon> debug prints that use the "new" debug print system: Thanks, this looks good to me. Approved-By: Tom Tromey Tom