From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id 385C93858D37 for ; Thu, 18 Apr 2024 15:31:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 385C93858D37 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 385C93858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713454321; cv=none; b=j8BcS+AF7/EadQi84eVt8wTiw5arp5NhnrAG6GnwuNzCACnO2yQsseDomRWzmU3Y58ewvo68m8O8o9kotI0ioaB8tiSLy7gQwm19vxEtg5JXjFTfDrRdVgN01SL1U8ykzuHGjtoujX3GZaBgFACJ1zb79Z76WgzHHNdG4Fv50zM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713454321; c=relaxed/simple; bh=F1gxzHEaywwTj2IZQ7vzmaF29jtD19gADU0OOQiSKI0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=jC74ScBpBYNV0GroCWt7gXjfX10+FJMk6bIHmPEbmEG5Cryr5o7TITpag/hxM11FVl+lqWguH/FyPthyQYWAQ7N5QwoJ9rbkn+/Cz11GvIZ7Mv+x09e/ezOdm4f1BxbE9bmla56p3wuE7bKlc2aYTaZ5KaEF5ERUGMqApD9cRQk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12d.google.com with SMTP id e9e14a558f8ab-36a23d5c31bso3768835ab.2 for ; Thu, 18 Apr 2024 08:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713454311; x=1714059111; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=F1gxzHEaywwTj2IZQ7vzmaF29jtD19gADU0OOQiSKI0=; b=Fr6rMqs/jZEh1vaAbrLeFHDxXpv6GO/iUvEgXbxPyyeUzrPMZmOY1DfaQs8hmeqTTm R0esEtQDsmBg665guoSSf41JeibL/CwC2O/OFYLhtFrwGDR5A9u8sccG8/Sk3wT/jytx cwluImBYzA/9Lb+G1o1YhrZb+2XPfqJyjlythcRc0pZvCfQaycSuVchh2pWnUzOWveb5 +q5m4aYIWQnSO2rbZvz70xpxoTLnIMjBugq73Z9pwDWCfhV+RynvK1+mTZbn5PY9ReK7 tSKf5OXrluoA2nVdNKy4x4fJHCMXo5LvD9HpB465z81+i63koNAXrmy3bPTqfmBmNbne TGCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713454311; x=1714059111; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1gxzHEaywwTj2IZQ7vzmaF29jtD19gADU0OOQiSKI0=; b=nYBIg8M4bM/8VN1pXRcFHypFHq6JT60jTCVPt8J+LpX6xElIsK5LjXwCmX1gychQHx CB1h++osb5veJTmCnOLrdsNNbMtqeVnbKhC6R5k+qwbayoVHmcwBzcbLl7DZzCkfuRqz kVfJTS4VIeaynkJMD0ZX6d3q3twfapnyklSHmwLdJDC4i/ZnVMCGsV7wKxxd2PBUCKud x8yzhUyF84AipqUDQ8GNEYWm2ZJf/MyLMa3MGVBKf8gvImnO3jLEkfsFKFusxi7z5uMk NM+LTliPWys2598+RORsPRR3OgLKMLvuKhwWJUVg3eZktg67PoG1fNDIXs1dsNtcGLef hFnw== X-Forwarded-Encrypted: i=1; AJvYcCUcib61mM6YF9rtnbgLLSEryveeTKcrjVUubmXgqIVmJfJXv8XCnKFp19V11kOJ7KqLuGI87O4TuImyeDNjOi9SFeq+genngNKeoQ== X-Gm-Message-State: AOJu0YzfRGbHdq1v6bH93tCibf6CJYZKO//2fuR9rzk20YEnuppGZf4g fGdZZZhSUq6o8eO8uh6jtLdEH7uw+bgnua3icggZqgtC+QiWYJFqugzYcv/TLQ== X-Google-Smtp-Source: AGHT+IGFYkhcW5pQi9U2euh6QKS7Kx5VLGmtWUxI+tu4p62q8kI2+tx6vD59HQTM10WT5mZhy6bfiA== X-Received: by 2002:a05:6e02:1fe6:b0:36a:2970:5254 with SMTP id dt6-20020a056e021fe600b0036a29705254mr3159230ilb.18.1713454311457; Thu, 18 Apr 2024 08:31:51 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id z10-20020a92cb8a000000b0036b1f6b245asm360775ilo.55.2024.04.18.08.31.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 08:31:51 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Add an include-checking script References: <20240417-header-check-v1-0-a60f610f5bcc@adacore.com> <20240417-header-check-v1-2-a60f610f5bcc@adacore.com> <6ead9447-de50-45fd-b18b-cd68f8824f76@suse.de> X-Attribution: Tom Date: Thu, 18 Apr 2024 09:31:50 -0600 In-Reply-To: <6ead9447-de50-45fd-b18b-cd68f8824f76@suse.de> (Tom de Vries's message of "Thu, 18 Apr 2024 14:54:09 +0200") Message-ID: <87bk66znyx.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> The only thing I ran into was that the corner-case of an empty file: Thanks, I fixed this. Also I found out that if a pre-commit hook modifies a file, pre-commit will still DTRT (fail), so error messages aren't needed in this case. I've updated the script to do this. Tom