Re: [PATCH] Remove 'if' from GDB_PY_HANDLE_EXCEPTION

[Tom Tromey <tom@tromey.com>]

Simon> In infpy_write_memory for instance, GDB_PY_HANDLE_EXCEPTION is not
Simon> called within the catch block.  Is it normal?

> Nope, oops.  Here's v2, that fixes this and also removes an unnecessary
> return -- which is kind of the main motivation of this change, the 'if'
> sometimes results in the compiler thinking the macro doesn't return,
> whereas it does.

>     Remove 'if' from GDB_PY_HANDLE_EXCEPTION
    
>     This removes the embedded 'if' from GDB_PY_HANDLE_EXCEPTION and
>     GDB_PY_SET_HANDLE_EXCEPTION.  I believe this 'if' was necessary with
>     the old gdb try/catch macros, but it no longer is: these should only
>     ever be called from a 'catch' block, where it's already known that an
>     exception was thrown.
    
>     Simon pointed out, though, that in a few spots, these were in facts
>     called outside of 'catch' blocks.  This patch cleans up these spots.
>     I also found one spot where a redundant 'return nullptr' could be
>     removed.

I'm checking this in.

Tom