From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 04EF83858C74 for ; Thu, 8 Feb 2024 23:47:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 04EF83858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 04EF83858C74 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::633 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707436030; cv=none; b=c3G51+ey32IM3XMIvxkWrTzni1KUbXDCPy0aaZMOocSvfHL7Hdu4JUYUd28CLYfLMVznrF+Oz2Kdj/JxYGOtnhgyDeM6QD1qesjpXvQcOlx+/W70tsfVKKjau/4bDRtdoy+JpfRX2J+9viy8S3uYbN/n3QzchWFXrkKyR2R6qVw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707436030; c=relaxed/simple; bh=dCWYfQfjW/ELF117KBJgVcjxVRpZ3SMLhDhbPODrPkY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ZmKrgEnPdESP9jZib525ix1cmzEVGOz2Mo0ymppi+opS8prpXxjTPTyS6qvxG9cwggXlay+O5HxqHzNjdasmAdzgsajiE9f+SPrHFbHa/M3TBkVoj3+BofL4qpXz/vi5BCh4mKA7m2RuoBCPHR+8E4TE2QPxrcyG+BSWvQ9Mhu4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1d74045c463so3182585ad.3 for ; Thu, 08 Feb 2024 15:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1707436027; x=1708040827; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=ydNOSU5l+Q0P424QqESJj6nqSw36W3ve+tpqvm8wrFQ=; b=ckyjFU4cuT+PJP6IgWI2SvxnFqT60NpTJTw/HFcsIf89pec20T3V8Ed4EMe9tH6sTf 1ld+fvG0TRRptkx1Tn/G09JlNUm9w54bFFy9AxljfST92fF+AOc9DHrTOaPBMGJcudtz JwXbPPwxDFR6zKqRGo6r+oXDqPkZCuQUBMfMKgTkGIE25Bm+2icMoL0VymndAbmj7atp H6BxB59b4SfSDKdbFlpnl5Qo7l3NtYXNWEYTnHMvBG0bgZOHKZwo1kknECsaMjcu0Gp5 3DD7KRn66uQ/yXsdJHDrmuzsc1JjDaIuVI7gPxe9ZkAfrCCnmeg84I6oWBTN4UEKmL5A h6Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707436027; x=1708040827; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ydNOSU5l+Q0P424QqESJj6nqSw36W3ve+tpqvm8wrFQ=; b=mTXWObbaI4m47lByMfjoEbloNUSS48n2op9/eYTTAecnA37T1aWZvw89uGoHKqBf3Y JXpoUj46wiVztkj34s6dtmsndAFPpmSpmBbJnEKilHl+ngwYfv26h/bpuCFqSfm3EVWw oiduOe3vZ6vQfQi+fMVhU5d7AWpI714A6oChxzBB1T+iIzuL3VgFdGOkilSFqTIvXEjR WDRqKAyxR2Nlp6rBPayeVwrx7lkZGSiOFJ+iT8hlE8O0FeLKY3qdkhviRViZwkiDZRuy Eq3LjpM8kR67lIBW6kgaH/sUji7od63TiJSuyfGqXfvvXlI55i4T+MpOAHaY8ub5/4c7 JCMQ== X-Forwarded-Encrypted: i=1; AJvYcCVgrt7Fs20FkkvMQc+OGqG3iN4qMFze0LPf4eIMK9TfCO9h75E/B5+JR9FvIo2lMSyTxyzv0gPh9Bb1tnPqFKsq0gIBEF0+q1l6SA== X-Gm-Message-State: AOJu0YzGjML3jKczdYcZybKTMXgKGXoJhdC8Spj7C1zdqCg3mhdMOed5 uxGzIcpNL7APjqCOYr6uxL+ms1ii+vfWf2U0mNRC+V/QaRPskLgyC17HtodAoL3tjIwG4jSyKiP o X-Google-Smtp-Source: AGHT+IH9RGutNOrpSsQOIxM7tHV/Err8Mw7lONgZOqkgMOrvA2jqcnS1ZmnmtuAJUsBNJieiHx8lFA== X-Received: by 2002:a17:902:f54d:b0:1d9:f00c:1dd5 with SMTP id h13-20020a170902f54d00b001d9f00c1dd5mr736786plf.63.1707436026960; Thu, 08 Feb 2024 15:47:06 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCX4Kw+dzinfJwFkobHto4NbwQCc4Jg0eyEjCF41V0/8DOn9fdGklfCIAvD6uqn6ldG4sGcYDV+Cx/e1PT86tS5SNLsD/gjG7jVQ2A== Received: from localhost ([2804:14d:7e39:8470:459f:5bdd:7fbb:2ae1]) by smtp.gmail.com with ESMTPSA id x5-20020a170902e04500b001d8fe6cd0f0sm322157plx.150.2024.02.08.15.47.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 15:47:06 -0800 (PST) References: <20240111025921.781828-1-thiago.bauermann@linaro.org> <89c9eb1c-3463-4222-9d48-3ab04386d1db@redhat.com> <87le7v9bck.fsf@tromey.com> User-agent: mu4e 1.10.8; emacs 29.1 From: Thiago Jung Bauermann To: Tom Tromey Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Fix testing of "info copying" In-reply-to: <87le7v9bck.fsf@tromey.com> Date: Thu, 08 Feb 2024 20:47:04 -0300 Message-ID: <87bk8qy0w7.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Keith" == Keith Seitz writes: > > Keith> While I'm not really in favor of copying large swaths of text from > Keith> compiled code into the test suite, this text changes very infrequently. > Keith> I think the last time it was updated was around 2007? > > Keith> So I think this is easily outweighed by the need to strive for > Keith> more deterministic test results. Yes, I agree it's not ideal but in this case I think it's reasonable. > Keith> Reviewed-by: Keith Seitz Thank you for your review! > Makes sense to me. I didn't see this go in, so: > > Approved-By: Tom Tromey Thank you! Pushed as commit 0fbd03fda1b6. -- Thiago