From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id 05EC03858D33 for ; Fri, 22 Dec 2023 16:52:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05EC03858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 05EC03858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703263958; cv=none; b=rkF/8X7xsBLX3r+GJuDyJXPUuTcEqdl7jkXg0Jd3pDyVcSi99WnhZP+a5lcS6cwr+n32jAh1eW213pxx8Pza3eAmR1Zy1giZ3r70a5RzaCagEdVS/Yop3NXrvWP4Fr6VyxASPDFrT6t7yAg8teQJTp7wis7vGUwjVz+p2PcQcy4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703263958; c=relaxed/simple; bh=aI1umIgdsDbc0/Yh+8SFrvQfTAkCkbUGY76Q69zOpjs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JNsSK/4L+BAwH1gv5VO0na8FG/zW3bRMYHY4skOQ68iOz56GYRGbnTDTML63Bt4I7e2VKSgYRvGgls0MvoA+H4WKCiDiUeGXf4CEnWh8q74l1TXYUmwMYEVcSkJX0fUwXuP0+zXcFcA7XiOyBKAgBmy/NnLsjoyvq6k5xEFbUUM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5006a.ext.cloudfilter.net ([10.0.29.179]) by cmsmtp with ESMTPS id GcK3rKRrfVly7GilIrGXJ3; Fri, 22 Dec 2023 16:52:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id GilGrPw5B1J28GilHreB76; Fri, 22 Dec 2023 16:52:35 +0000 X-Authority-Analysis: v=2.4 cv=Tqz1ORbh c=1 sm=1 tr=0 ts=6585bed3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=7d_E57ReAAAA:8 a=s_bzVB2HeN74CjNf8koA:9 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=p4Qm9pwKLlr47M7OcZHIGmkJgTW2Ulp/41q5vP75QIw=; b=BSjZ0ODDi1y6JIuYYbOS8FWPyy X1U9B4ueM1djsmzFTDaOTnCDHU98h1BEdqaSYu+mQVqsNygz7sX99SS5izGBVw4rUTbVkm2T4I1Nw rTY/cH5sSo0hq2b2tJlyUUKo1; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:56952 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rGilG-003OEH-1q; Fri, 22 Dec 2023 09:52:34 -0700 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] gdb: remove VALUE_REGNUM, add value::regnum References: <20231221191716.257256-1-simon.marchi@efficios.com> <20231221191716.257256-9-simon.marchi@efficios.com> X-Attribution: Tom Date: Fri, 22 Dec 2023 09:52:34 -0700 In-Reply-To: <20231221191716.257256-9-simon.marchi@efficios.com> (Simon Marchi's message of "Thu, 21 Dec 2023 14:16:29 -0500") Message-ID: <87bkai18od.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rGilG-003OEH-1q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:56952 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJLizkTbP/OdfgzvyD8tp8VidiowdPpfF9IFgTtHHPog8+utDUL67FtH8XjucJElk/7LpPc/YisG1rcVxchzkVRnpL+VzdHKPV9VeaFz3hDhn26Bk1ek 5TE8EyDA1306dE4w8+aweFgp47ePf1jwwBehXFsNDUisduviOStcNiF7U0HHHwHLnKqWlkARkVnnyYNHNgZ8xmOVY13P5+lbMdM= X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> +/* See value.h. */ Simon> + Simon> +int Simon> +value::regnum () Simon> { Simon> gdb_assert (m_lval == lval_register); Simon> - return &m_location.reg.regnum; Simon> + Simon> + return m_location.reg.regnum; I wonder if this could just be inlined in the header. Tom