From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 953AB3858C35 for ; Mon, 27 Nov 2023 22:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 953AB3858C35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 953AB3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701123722; cv=none; b=nX/ZJmAf2Kv0tbwFuI3nJua2p/7ngUf1TTN17m9CODgSYxCHVd1y6W0SnACC3p0Us8wvBIWdZC9dxCkVwoPzAiDFI+LFCqv/x2Z5xazCt6lmWWFvZZGljW1OdWYpnu0XXl0dXgSgkIvMqSJyTuW/Wl4QIKW0zUebQFcBc5HRonw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701123722; c=relaxed/simple; bh=eGsHvlzMDSS+755Pr+ge0/xkWB9UCuG8y9G9OJyscAE=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=OgQMNNJZT824n03lhD3LmqaCVgEInIrtyfZA90K4ZaqEwGQVI7gj2LuyG3cKBrvBDM71whaqIZ8wdrqO46RZbKGPjRAJtcZH/woF8iMXg8PLqkQh9SF/j1HueCvf4mu7Yg+0WHcmrz+j+uH78pS61XEkTFz2F2vraNo+PO0PoOQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701123721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9yGAZvuTE2n7BhZ1Z7s/pI0mmxVUrn5EQlN7wi0koTw=; b=IibQ//rYt3U3hv6CYgLS5+fNuc45N7AHCr/9I0Oe2a8uwKNRXcRvF4I22PF0ww2rknO8rd 9cOOLGbP3bOiBWBdtptrCZfB1VjG5ZxPhdL+q+l/00odk02Z2BYrHNug3uFTcNVWqGi2qh t/etV8W0wvEz5TwnGuy9TQTKTXgjqJE= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-478-Fvh8yRTWNnK5TVMr2fovew-1; Mon, 27 Nov 2023 17:21:59 -0500 X-MC-Unique: Fvh8yRTWNnK5TVMr2fovew-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2c9a90e8d30so7948951fa.1 for ; Mon, 27 Nov 2023 14:21:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701123718; x=1701728518; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9yGAZvuTE2n7BhZ1Z7s/pI0mmxVUrn5EQlN7wi0koTw=; b=AK8lubuZU0rxMul7VCN742KxDy05QI5n8icRPxL+ZYhGiernTA/6FkpQWqsiVHXc0y Wj+n581Cfy/bzcn33yGleB5LyeKoVYY5g07uVNGMWykurBSF8voLaNK7XPpHIulXv/vV 9d7arDqWnOZxRF+jbrFZJ/0WSEXEDFIYpwezTkQr792rEEgk5zmchHVQspLBsXigwqrJ w71muz0W6vKCRJ0PwQEQCoTBM9E+8aAAWB5CltGZwu3Q8JEXP6qS2LRTeyEg3v2szJjW QRi5a41UC28S/UVvlFg4Wb4qDWiaAH+paoteCQIackc/t2Hm9fPQbIXkEWVN+KlqVJW7 o5Rw== X-Gm-Message-State: AOJu0YwgxXagBYn1u8ZoB5SJbyfRCj2zWuDXSupNL/1Z3QLFLSTrBlQT zOSOTQzRI4tuztEDz8wRvX/uNe53vHVaUF4xHl++V+LCOrVd6USFMYdVawqqMfFFyILPAlDKle/ hUmJMnpieqEfK6418RiXrG1DANuYndQ== X-Received: by 2002:a05:651c:106b:b0:2c9:a361:3062 with SMTP id y11-20020a05651c106b00b002c9a3613062mr2900218ljm.1.1701123718310; Mon, 27 Nov 2023 14:21:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IH4Fl5BJa9KerOr3C/UNTLLl9HBAa6C3vpAUdjl5qHXupW72GU5WTxE37P4FXpXLU4VcrAY5g== X-Received: by 2002:a05:651c:106b:b0:2c9:a361:3062 with SMTP id y11-20020a05651c106b00b002c9a3613062mr2900209ljm.1.1701123717974; Mon, 27 Nov 2023 14:21:57 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id hg15-20020a05600c538f00b0040849ce7116sm15872125wmb.43.2023.11.27.14.21.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Nov 2023 14:21:57 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/7] gdb: C++-ify mapped_symtab from dwarf2/index-write.c In-Reply-To: <8734wrf2ai.fsf@tromey.com> References: <8734wrf2ai.fsf@tromey.com> Date: Mon, 27 Nov 2023 22:21:56 +0000 Message-ID: <87bkbeq1kr.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> mapped_symtab class can be treated like a contained and iterated > > s/contained/container > > Andrew> + /* Access the obstack. */ > Andrew> + auto_obstack *obstack () > > A real nit, but it is probably better to just return 'struct obstack *' > here. Returning an auto_obstack makes it seem like the special auto- > behavior is important somewhere, but it isn't and/or shouldn't be. I'll change this and re-test. Thanks, Andrew