From: Tom Tromey <tom@tromey.com>
To: Pedro Alves <pedro@palves.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix Windows sharing_input_terminal hang
Date: Tue, 22 Aug 2023 09:39:07 -0600 [thread overview]
Message-ID: <87bkezw0h0.fsf@tromey.com> (raw)
In-Reply-To: <20230822151332.4010554-1-pedro@palves.net> (Pedro Alves's message of "Tue, 22 Aug 2023 16:13:32 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
Pedro> In this case, the buffer wasn't too small, it was exactly the right
Pedro> size, so we should have broken out of the loop. We didn't due to a
Pedro> "<" check that should have been "<=". That is fixed by this patch.
Looks good to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-08-22 15:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:13 Pedro Alves
2023-08-22 15:39 ` Tom Tromey [this message]
2023-08-22 15:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkezw0h0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).