From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id E9C4B3858C5F for ; Fri, 4 Aug 2023 15:57:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E9C4B3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-348ddac3a09so8647295ab.1 for ; Fri, 04 Aug 2023 08:57:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1691164673; x=1691769473; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=R1NGL+Rk4VyYaxw/Pr/Za8QgkrySQbg4SLjf/8HhHQs=; b=HP8zfmn9Y2FhxnVdTBMHXQyTC3G+tPAyyd4usmkWZBbwx8rbC3wKrn2K9wK3SfcHt0 sIWyuk36FBF+LF1L2DPmvI9VTrq2MtPqoYpUZEVNlYNIpD9OxCCCm4ESx35JLvApAg9q Cf8PRFKoOb/v39Vp6IsahP4uWk7YWiNeQrpodUz9d/oMRyiGx8DR7bjl2lQIpbUwmfWT OELl/SPGAhj7B+foQ/jCAhr0zNbqIf8I0h7V2vRU3z1WrWAE3QtC+XJuEDeQO2sdwiKb +XIHprNUFHfFZZFXwX3VJR8tcaK8sh/TJdPfV+KQQQCKjF+LiXFJQSLWr2iV5Zhb6iUK syPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691164673; x=1691769473; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R1NGL+Rk4VyYaxw/Pr/Za8QgkrySQbg4SLjf/8HhHQs=; b=MES81hFuYqV4Lmm/sgEMA8iiQ+f2uWrWGdMRNdYEzz81gia21XF8kNks0Mu5NS4FhH ryvd9TkawvA+mj8+uTHFWzfq/3j5ImoeUzAn8MtMkI1wXI8iS1i7U6ZFoBV0zOoUSi0B 2XFGpmIn9zrM2czhxwzCt1UnR8wfQEDevm9N65Ga7YWyjpPkwtmV4BMOzyyFnjyvJMaC Cv2TAmbcJkY3Hr4i71vIpQ9TuEDWoqmHN2NZ00EReYvtVhITKXnHrlR7UADRYs7pwkyt nfPu6H7TX/qZS4ix3yikHlIJcoeqRxMnkFt0QilBkEJJN1DbSz70G/Wws5Zb1E3bmaz8 7HVg== X-Gm-Message-State: AOJu0Yy+SRn+D4lX9UKcw0tx92H6Pbt3cO8W7WiiBUJtWRYLbhtHgL0t b9xO0P9MWFSktn2uBG2gYgcN+6G9sxc8ONClAIv1XA== X-Google-Smtp-Source: AGHT+IFFUVve21dGoI0ut+QlFPgZD3IflqH5HlB+qpAhSYs2oroM2Kw7haVeJdb+0ryt6eF/98K2aA== X-Received: by 2002:a05:6e02:1a83:b0:345:873d:1102 with SMTP id k3-20020a056e021a8300b00345873d1102mr76435ilv.15.1691164673351; Fri, 04 Aug 2023 08:57:53 -0700 (PDT) Received: from murgatroyd (71-211-152-221.hlrn.qwest.net. [71.211.152.221]) by smtp.gmail.com with ESMTPSA id s13-20020a02c50d000000b0042bbfe3dc42sm627857jam.173.2023.08.04.08.57.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Aug 2023 08:57:52 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom de Vries via Gdb-patches Subject: Re: [PATCH v2 2/6] [gdb/symtab] Fix data race on bfd::{cacheable,format} References: <20230802095305.3668-1-tdevries@suse.de> <20230802095305.3668-3-tdevries@suse.de> <87o7jpdyub.fsf@tromey.com> X-Attribution: Tom Date: Fri, 04 Aug 2023 09:57:52 -0600 In-Reply-To: (Tom de Vries's message of "Fri, 4 Aug 2023 02:09:59 +0200") Message-ID: <87bkfmby0v.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> In the v3 version, I've added explicit in the first patch, and then Tom> remove it in the second ( Tom> https://sourceware.org/pipermail/gdb-patches/2023-August/201338.html Tom> ). Sorry about that. IMO it's fine to just leave it out in a situation like this, and push back on the review comment in that case as well. Tom