From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id 7BCCF3858C83 for ; Fri, 21 Apr 2023 14:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BCCF3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id DC68A1004C006 for ; Fri, 21 Apr 2023 14:44:29 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id przxpKePs2crfprzxpGqXe; Fri, 21 Apr 2023 14:44:29 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=WNG64lgR c=1 sm=1 tr=0 ts=6442a14d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=lzDhS8hmAAAA:8 a=ncaCMu0wor8OE4_efxkA:9 a=rigQk1bY_8VmChEzA3fK:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S+9vY9ar6oeAO6lDZt1V5a3W1uxLe0sAMZwl8VL3CjM=; b=Ehx6W7/OiB110ibCcWftlxcnOh dc9Tx3FoFL9ACVZjkV0GK/xF2L+HPLj00PxWRXpUX86qVs4eWS4V7CQXVj69EukvQWvlYRm/J4AYr lRs28mvFpOb9KZPbndKG/+rd6; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:43732 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pprzx-002LK3-Kr; Fri, 21 Apr 2023 08:44:29 -0600 From: Tom Tromey To: Sandra Loosemore Cc: Subject: Re: [PATCH 3/5] gdb/testsuite: Adjust some testcases to allow Windows pathnames References: <20230419193046.548783-1-sandra@codesourcery.com> <20230419193046.548783-4-sandra@codesourcery.com> X-Attribution: Tom Date: Fri, 21 Apr 2023 08:44:28 -0600 In-Reply-To: <20230419193046.548783-4-sandra@codesourcery.com> (Sandra Loosemore's message of "Wed, 19 Apr 2023 13:30:44 -0600") Message-ID: <87bkjh1eib.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pprzx-002LK3-Kr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:43732 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Sandra" == Sandra Loosemore writes: Sandra> This patch fixes some testcases that formerly had patterns with Sandra> hardwired "/" pathname separators in them, which broke when testing on Sandra> (remote) Windows host. Sandra> + set STRINGHOME "" Sandra> set test "show environment HOME" Sandra> gdb_test_multiple $test $test { Sandra> -re "\nHOME = (\[^\r\n\]*)\[\r\n\]+$::gdb_prompt $" { Sandra> set HOME $expect_out(1,string) Sandra> + if { [ishost *-*-mingw*] } { Sandra> + # Backslashes in the pathname must be escaped for the patterns Sandra> + # that match quoted string output. Sandra> + regsub -all {\\} $HOME {\\\\} STRINGHOME I don't understand this one, because the uses all use string_to_regexp. But if the computed value of HOME doesn't work in that context, then it seems like that means there is a bug in string_to_regexp, because the contract of string_to_regexp is to return a regexp that will exactly match the input, no matter what it is. Sandra> - "The filename in which to record the command history is \"[string_to_regexp $HOME]/foobar.baz\"..*" \ Sandra> + "The filename in which to record the command history is \"[string_to_regexp $HOME].foobar.baz\"..*" \ Also why didn't this one need to be changed? (Though if there really is a bug in string_to_regexp then it's irrelevant.) Tom