From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x131.google.com (mail-il1-x131.google.com [IPv6:2607:f8b0:4864:20::131]) by sourceware.org (Postfix) with ESMTPS id 2A4C83858D1E for ; Mon, 13 Mar 2023 18:46:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A4C83858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x131.google.com with SMTP id i19so7405132ila.10 for ; Mon, 13 Mar 2023 11:46:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678733200; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=542HOi+VxALy6JT9NacIw+fch4XCi+WhaJ2bcBhH/yI=; b=Kvs2lsQbGjVb7zRLg8V8h61GdvAqgwONR31BbXZuvJ+psIET6rHAMLGzsLdtQVxN4k Rbm/ypJ3x3FO0O8XbcW3GHlA/f2m/v52AmTlH/Xob4DN3LKKRCo6CqRXp2jKLnJf+isI 8nonAagXyVWBGflBU+uH6Btxjr+A21G1vM8hNsDNWbjOf6NETwaeIR65NS8nONlf6ikI agB5hK/E+f3UJtxYLGPILC5Mwfi3VhC+sQFl0PN3NBV+xJCUtg6d7j2cNbjgDAckUec9 JPduPMSAk2LuoS4EZNyP1yIBRCs56+o33i4QtGs236SbDw8Pd4JbKJ8/lviVtbeXJGwe GybQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678733200; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=542HOi+VxALy6JT9NacIw+fch4XCi+WhaJ2bcBhH/yI=; b=s1o1BsDHNHUosryzJdPn9wAKgOxZywkHj98Gt2dfy0000a2Ngnb1qVBc7psrjd6G7x AGdFxhZvzgbltGc/AGC9ulRaWEf16lE9BGY56gbq8rPsHtf8tuqB4xbmci+itv85fU9Y N6KX9641D0z6bryawtgYVG91HtqYhDCnbuoFNYvlC7G8wKxAHuRiXAN7Gw/EYdwG7ctG 9G2nsN8N14plqg9P5KsmyxGnceAB/H8Q7cM/7EU3o/eHbnri7whFpAaHZQfrRwU7JLNf lqu3k6u9gsgPZ1I0sOFK+nlESSUFWyquH+f1Ces3JK3c0r1NmlXhQdfLCf+QVkhocvC8 Rllw== X-Gm-Message-State: AO0yUKWWAiHw2yi4V853opOGVdmpAfMy/lZ6W3fiunqoYAJKqyqEpQl7 v5Lig5l6FiGY/IW9VFAhU4EB0g== X-Google-Smtp-Source: AK7set/atzE0r5nmSQF4yRD1zaMBhm0YVXmL+CxU2jTtABnElZa0sRABTjBf4sFA50TC2aM1+tEdjw== X-Received: by 2002:a92:7d12:0:b0:318:cda9:c60d with SMTP id y18-20020a927d12000000b00318cda9c60dmr452530ilc.14.1678733200396; Mon, 13 Mar 2023 11:46:40 -0700 (PDT) Received: from murgatroyd (71-211-185-113.hlrn.qwest.net. [71.211.185.113]) by smtp.gmail.com with ESMTPSA id o2-20020a92d4c2000000b00322fe7f3d8asm165392ilm.22.2023.03.13.11.46.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 11:46:39 -0700 (PDT) From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Tom Tromey via Gdb-patches Subject: Re: [PATCH] Fix DAP stackTrace through frames without debuginfo References: <20230215194847.3805619-1-tromey@adacore.com> <874jqx7vux.fsf@tromey.com> <87fsaenfj9.fsf@tromey.com> <1c5fbdb3-4307-eba8-9976-673a11655bee@suse.de> <87356dojbh.fsf@tromey.com> X-Attribution: Tom Date: Mon, 13 Mar 2023 12:46:39 -0600 In-Reply-To: (Tom de Vries's message of "Thu, 9 Mar 2023 21:35:15 +0100") Message-ID: <87bkkwlca8.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries writes: Tom> Sorry, yet another error. I do not understand this one. Tom> File "/data/vries/gdb/leap-15-4/build/gdb/data-directory/python/gdb/dap/frames.py", line 49, in frame_id Tom> return _frame_ids[frame] Tom> KeyError: I don't really know what's going wrong here. I wonder if the new hash function could be incorrect. Like, if the contents of the frame id change, causing the hash to change, then this would presumably break the Python hash table. Instead of a hash I can change this to use a list I suppose. Tom