From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy2-pub.mail.unifiedlayer.com (gproxy2-pub.mail.unifiedlayer.com [69.89.18.3]) by sourceware.org (Postfix) with ESMTPS id D9A1E3857C45 for ; Fri, 24 Feb 2023 22:07:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D9A1E3857C45 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway4.mail.pro1.eigbox.com (Postfix) with ESMTP id 34AC010047A33 for ; Fri, 24 Feb 2023 22:07:21 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VgDppqZ8zPH6mVgDpp42g8; Fri, 24 Feb 2023 22:07:21 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=evcacqlX c=1 sm=1 tr=0 ts=63f93519 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=W3P1JrNfQAvHDHUIF5sA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OQyUeYjBOP2hOVeYBGECr3s6/Z7n5FnQ6003z0VRxtE=; b=DHsidCoo51XNlzy+frBVzf945n Qn+FqJJNPUhUCnLOg9B1Q4hSBFnGFuwKo405r0NFlygNZkaFIk5DBOL/P/1pZopn5OOtVLeb3KPxf EzNwgGNWJYDKyPkb1P9lbInTz; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:43278 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVgDo-004Mwh-Rx; Fri, 24 Feb 2023 15:07:20 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi via Gdb-patches , Simon Marchi Subject: Re: [PATCH 3/9] gdb: gdbarch.py: spell out parameters of _Component.__init__ References: <20230223221830.499934-1-simon.marchi@efficios.com> <20230223221830.499934-4-simon.marchi@efficios.com> <87bklihmf6.fsf@tromey.com> <3a019b47-5dab-def1-807c-c8fbcf63872e@polymtl.ca> X-Attribution: Tom Date: Fri, 24 Feb 2023 15:07:18 -0700 In-Reply-To: <3a019b47-5dab-def1-807c-c8fbcf63872e@polymtl.ca> (Simon Marchi's message of "Fri, 24 Feb 2023 15:31:59 -0500") Message-ID: <87bkli3eg9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVgDo-004Mwh-Rx X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:43278 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> Huh, it's unfortunate that the type checker does not understand at this Simon> point that predicate (set in _Component.__init__ is a bool). It does Simon> understand it at other places. Simon> I don't understand why this assignment to None is there though. Wasn't Simon> predicate None by default anyway? Can we remove it, and in turn remove Simon> Info.__init__? If I do that, I see no diff in the generated files. I don't really know, I was wondering if there's some intervening class in the hierarchy. But if removing it has no effect, then that seems best. Tom