From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id DCF3C385840F for ; Fri, 24 Feb 2023 19:06:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DCF3C385840F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id AF28110044F68 for ; Fri, 24 Feb 2023 19:06:25 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VdOjpM7KHTQEGVdOjphN0M; Fri, 24 Feb 2023 19:06:25 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=N7Tsq0xB c=1 sm=1 tr=0 ts=63f90ab1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=q15rRnnw5kioppgzgagA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ljGVVIScTcmuA8evBLIO7Ms113+xlhp4j2U6lU5SDcM=; b=mGYlSNCQ8UdKBwiUQIJJQ+AUMM HClQAAOsDtCCnVyRX+a/GABR89QqM4u08FiwnD6Uq5WVc6nQOfQsEmJRs7Ca6sSlCcAsUHMSS8g8k FIr+Hl68rz5cE6opeypSSIcyN; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:39276 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pVdOj-001iDU-9C; Fri, 24 Feb 2023 12:06:25 -0700 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Bruno Larsen Subject: Re: [PATCH] gdb/testsuite: Improve testing of GDB's completion functions References: <20230222091110.2995513-1-blarsen@redhat.com> X-Attribution: Tom Date: Fri, 24 Feb 2023 12:06:23 -0700 In-Reply-To: <20230222091110.2995513-1-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Wed, 22 Feb 2023 10:11:10 +0100") Message-ID: <87bklij32o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pVdOj-001iDU-9C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:39276 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> When looking at some failures of gdb.linespec/cp-completion-aliases.exp, Bruno> I noticed that when a completion test will fail, it always fails with a Bruno> timeout. This is because most completion tests use gdb_test_multiple Bruno> and only add a check for the correct output. This commit adds new Bruno> options for both, tab and command completion. Looks good to me. Approved-By: Tom Tromey Tom