From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy6-pub.mail.unifiedlayer.com (qproxy6-pub.mail.unifiedlayer.com [69.89.23.12]) by sourceware.org (Postfix) with ESMTPS id 5855F3858D1E for ; Tue, 14 Feb 2023 15:14:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5855F3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by qproxy6.mail.unifiedlayer.com (Postfix) with ESMTP id 82E8480331DC for ; Tue, 14 Feb 2023 15:14:52 +0000 (UTC) Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 61A5E1003FCD3 for ; Tue, 14 Feb 2023 15:14:07 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Rx0Rp6xskaJXNRx0RpN5XA; Tue, 14 Feb 2023 15:14:07 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=ZpQol/3G c=1 sm=1 tr=0 ts=63eba53f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=18QTLAY168o-OlKfyV8A:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bagqmYFlnp5qZq1abfLoOzfiWtOd9iskSpUffvLtBYo=; b=uVL/LGLAXtEsETod37fOIfhx6l FFN7ajiMLnQmMoRV3ue8SKzeoKVsgsRJfz1DBXG9496cyKTmUrjRK0ne92+jPDMorg2xJr3ztV14o +cFtpHIYXf3QnWyS6GxaP3sDK; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:54470 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRx0R-002dSB-2h; Tue, 14 Feb 2023 08:14:07 -0700 From: Tom Tromey To: Felix Willgerodt via Gdb-patches Cc: Felix Willgerodt Subject: Re: [PATCH 1/1] gdb, fortran: Fix quad floating-point type for ifort compiler. References: <20230214110049.649769-1-felix.willgerodt@intel.com> X-Attribution: Tom Date: Tue, 14 Feb 2023 08:14:03 -0700 In-Reply-To: <20230214110049.649769-1-felix.willgerodt@intel.com> (Felix Willgerodt via Gdb-patches's message of "Tue, 14 Feb 2023 12:00:49 +0100") Message-ID: <87bklwuvno.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRx0R-002dSB-2h X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:54470 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Felix" == Felix Willgerodt via Gdb-patches writes: Felix> I fixed this a while ago for ifx, one of the two Intel compilers, in Felix> 8d624a9d8050ca96e154215c7858ac5c2d8b0b19. Felix> Apparently I missed that the older ifort Intel compiler actually emits Felix> slightly different debug info again: Thank you, this is ok. Approved-By: Tom Tromey Felix> @@ -8238,12 +8238,14 @@ i386_floatformat_for_type (struct gdbarch *gdbarch, Felix> || strcmp (name, "_Float128") == 0 Felix> || strcmp (name, "complex _Float128") == 0 Felix> || strcmp (name, "complex(kind=16)") == 0 Felix> + || strcmp (name, "COMPLEX(16)") == 0 Felix> || strcmp (name, "complex*32") == 0 Felix> || strcmp (name, "COMPLEX*32") == 0 Felix> || strcmp (name, "quad complex") == 0 Felix> || strcmp (name, "real(kind=16)") == 0 Felix> || strcmp (name, "real*16") == 0 Felix> - || strcmp (name, "REAL*16") == 0) Felix> + || strcmp (name, "REAL*16") == 0 Felix> + || strcmp (name, "REAL(16)") == 0) Felix> return floatformats_ieee_quad; Not your fault but this whole approach seems bad. Tom