From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id 5C39D3858D1E for ; Mon, 13 Feb 2023 22:27:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5C39D3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id 31B7C803463A for ; Mon, 13 Feb 2023 22:27:06 +0000 (UTC) Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 27D1210040624 for ; Mon, 13 Feb 2023 22:26:46 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id RhHZptXoOFh3zRhHapJVlS; Mon, 13 Feb 2023 22:26:46 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QpabYX+d c=1 sm=1 tr=0 ts=63eab926 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=5g3ngRGdMGR3lLMeoTwA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=GUDLuH7MeuNjNBhv7TAssuEKpjKQYpi8fTayvPAm4b0=; b=DixEx5Hq1qBdvvvQt+OIaF9Fwr CkY8D80PkQLcF+4crsnuYFJn9n9mzFRf8IbCJHjBLTNjgzwQaUthyCvXacBqvy3WF6jow3i1kYK3F dgmUCPEnpkv09TDeF8EWCbC69; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:58384 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pRhHZ-000yHG-MU; Mon, 13 Feb 2023 15:26:45 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH v3 00/50] Use methods for struct value References: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> X-Attribution: Tom Date: Mon, 13 Feb 2023 15:26:43 -0700 In-Reply-To: <20230209-submit-value-fixups-2023-v3-0-45e91a20c742@tromey.com> (Tom Tromey's message of "Sun, 12 Feb 2023 20:15:16 -0700") Message-ID: <87bklxdwws.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pRhHZ-000yHG-MU X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:58384 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> This is v3 of the struct value series. The original cover letter is Tom> below. Tom> This series changes many value-related functions to be methods. It Tom> also moves the definition of struct value to value.h, so that callers Tom> will benefit by inlining the smaller methods. The members of value Tom> are all made private at the end of the series. I'm checking this in now. Simon reviewed the few remaining patches. I forgot to mention, but before submitting v3, I made sure that each revision could still be built. I also regtested the series as a whole. Tom