From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 1D38E3858000 for ; Sat, 11 Feb 2023 17:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D38E3858000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676137335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Gqkc2N9V9/gwSREMasdm74ATSdSEv1mYrIVV7XWdEvk=; b=g3Q8HEXopKKIYnre5PIjl+NpsbJIORvNLpkJqfILyoIDPT07a+amsYboZRfYREbdPO3g/L 6FMFb+qP0gA20292eT2lg69Jb6XTQVngcFJlhg8D/dughG9fwiOdEjawGk2J6WiWb4F15N NZ6RrppCfi/wQOy47GUj8skZB8c9gRQ= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-590-d6BgMsjFNhOGrPcOXsI-0Q-1; Sat, 11 Feb 2023 12:42:14 -0500 X-MC-Unique: d6BgMsjFNhOGrPcOXsI-0Q-1 Received: by mail-qk1-f200.google.com with SMTP id 130-20020a370588000000b0072fcbe20069so5302229qkf.22 for ; Sat, 11 Feb 2023 09:42:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gqkc2N9V9/gwSREMasdm74ATSdSEv1mYrIVV7XWdEvk=; b=CmuydUAFHdlSGQXL7VMjV8SQCsWawOocrJk3owT34JYkb072NtSOA3cdAe+2Jpnvhh Snk0nP07EdXdhvkW3e1DyhgbVoYAshaONt8FSkn8EAaTOGjhv1eGj+EUFbpTo5pOvnbV FeOlFXXcubPdTGjusM767lRGKDDuj8rmtO920UC0EFGA9bmWIsNO+EBUM6u/1o3wgOdL ppFz3/gtZ6SB/YvL5yPd2UiNTs92ZcaX5i7wA5GsI3Yh3fTB1UYs3UhG4hj6/NxMiPKs Y6WLMyrCW086GHqvzH6MThZmm0r+93ry74LQLGDETv2sWQLBHu4lcM3KMW26xt4XxqSP 4NVw== X-Gm-Message-State: AO0yUKWP5K3vRrqmcGCmkNhX/wVScBeQGDdWNwuFPVUyUdZ8UmEEoEms E/T3EVmhnPiAyy6/75m8kIaEDPTcMkUd2jJiSE+2naUPnBc31mu3A4OG0d/eT8aHAFnxHfrSndt BERl3y3HBhsX5V2Y6WpKlpw== X-Received: by 2002:a05:622a:1213:b0:3b6:8bc3:a09c with SMTP id y19-20020a05622a121300b003b68bc3a09cmr19301892qtx.25.1676137334039; Sat, 11 Feb 2023 09:42:14 -0800 (PST) X-Google-Smtp-Source: AK7set8ccHJZpK3mwECf4dFN4ceZbvOMz1Qoooph9kwiWidtSGkrUW45wzbZETKW5tF410MjoyY78Q== X-Received: by 2002:a05:622a:1213:b0:3b6:8bc3:a09c with SMTP id y19-20020a05622a121300b003b68bc3a09cmr19301871qtx.25.1676137333820; Sat, 11 Feb 2023 09:42:13 -0800 (PST) Received: from localhost (95.72.115.87.dyn.plus.net. [87.115.72.95]) by smtp.gmail.com with ESMTPSA id h25-20020ac87779000000b003b34650039bsm5730018qtu.76.2023.02.11.09.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 09:42:13 -0800 (PST) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdb: show task number in describe_other_breakpoints In-Reply-To: References: <8716dc72011765a13c3eee0b60a262fbcbd48d41.1675869497.git.aburgess@redhat.com> Date: Sat, 11 Feb 2023 17:42:11 +0000 Message-ID: <87bkm0umj0.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro Alves writes: > On 2023-02-08 3:23 p.m., Andrew Burgess via Gdb-patches wrote: > >> # Now, insert a breakpoint that should stop only if task 3 stops, and >> -# extract its number. >> -gdb_breakpoint "break_me task 3" message >> -set bp_number [get_integer_valueof "\$bpnum" -1] >> -if {$bp_number < 0} { >> - return >> -} >> +# extract its number. Use gdb_test here so that we can validate that >> +# the 'Breakpoint ... also set at' line correctly includes the task >> +# number of the prevoius breakpoint. > > prevoius -> previous > > Otherwise, > > Approved-By: Pedro Alves Fixed the typo and pushed. Thanks, Andrew