From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id B20553947438 for ; Fri, 10 Feb 2023 17:46:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B20553947438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 2CAA510047C00 for ; Fri, 10 Feb 2023 17:46:43 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QXTvpQhJ8O9zKQXTvptOIq; Fri, 10 Feb 2023 17:46:43 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=VccygHl9 c=1 sm=1 tr=0 ts=63e68303 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=dzWzf_mpAAAA:8 a=bhwLtD2LIm1BJcDb3xIA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=g73ctOEwBV/vudLSDJ0hbP1WXV43kJHSurf5Zfxy3RY=; b=bNr7OuLJb+NX8therKPgpgerVQ fLqukUokursb9CEmidYTLZpPb0OslYVIo9eOptTgJMDWDm1Q5RBGM7N7bzIDsHt5dD6NuA9E6EOet 9P1Dkmdi6pT+ynzsgwshqycih; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:37862 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pQXTu-001J2p-UJ; Fri, 10 Feb 2023 10:46:42 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 29/47] Turn value_contents_eq into a method References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> <20230209-submit-value-fixups-2023-v1-29-55dc2794dbb9@tromey.com> X-Attribution: Tom Date: Fri, 10 Feb 2023 10:46:40 -0700 In-Reply-To: (Simon Marchi's message of "Thu, 9 Feb 2023 21:18:41 -0500") Message-ID: <87bkm1ifb3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pQXTu-001J2p-UJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:37862 X-Source-Auth: tom+tromey.com X-Email-Count: 13 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3027.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> diff --git a/gdb/value.h b/gdb/value.h >> index e3574b3a169..2253784aedb 100644 >> --- a/gdb/value.h >> +++ b/gdb/value.h >> @@ -396,6 +396,66 @@ struct value >> it. */ >> void fetch_lazy (); >> >> + /* Compare LENGTH bytes of VAL1's contents starting at OFFSET1 with >> + LENGTH bytes of VAL2's contents starting at OFFSET2. Simon> The comments should be tweaked since VAL1 doesn't exist anymore. I fixed this, then looked at the final value.h to see if there were any others. I didn't find any. Tom