From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id DC4A0384D0EA for ; Fri, 18 Nov 2022 11:34:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DC4A0384D0EA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668771244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0gFMdr7bA33jqYHoET1eSS+6yD6VAoqTcvO/ryK0xos=; b=N0jppMLGRMMLIfAcfPxE2Ae3HkN7SRnIYqG5UYJnF7LgJfiPhkeJxis33YHkxG5p+RZUw9 pP1LxlD8nKwaRDGkoxvYP1vJnwmFlKf+mcJPottauLOnahm9P2HwDE8SPnq1Gk7sehGqDt zJUoulA36VgzyYSEaDeFg63c75hsCUc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-450-mbQFXarNPSGxBW795y-Lxw-1; Fri, 18 Nov 2022 06:34:02 -0500 X-MC-Unique: mbQFXarNPSGxBW795y-Lxw-1 Received: by mail-wm1-f71.google.com with SMTP id v125-20020a1cac83000000b003cfa148576dso2135539wme.3 for ; Fri, 18 Nov 2022 03:34:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0gFMdr7bA33jqYHoET1eSS+6yD6VAoqTcvO/ryK0xos=; b=qLeNe30ELo48xoyhhwt7MDEYHtJr/R/L6RVmnSBRys4/KVK1GxJBOsWiY+qH067ioZ mtFYRp6W7N8Hz2thAbzfa9EfBYy7jg7N5HnA5NsktWBHvWUhAK25ce3YWhPP7Qb3v5UW RBXnaxQaNde9WfDpa3XTEO82YqiqXTYarMriYG5bF0iOGBh2QmUFB3Mzew1KHRdMx7wR 17VWgBalmkdnKzUtiv8Mb945xdgDJJEv61yTUbwGA+1AY5z2q1oDCAIpsq36IqHHXHqd 8Yop2FYvpafWYtJ95JeswcUaYK7osfDdHxo8sXUN7wQdcX+/UwIR2+kL1ORW4goBWRz7 2MJQ== X-Gm-Message-State: ANoB5pls6N5Yp8njXKWFFiq0ZCHyF0fN8wT13LdNJPOnIB/k9h7ZCnx4 y2L9LjgeJ8xebGr44Q+xstNmXvWIjgAG+fidKLj2LIX8LjSUQHki6GTW2npI0nqjIbgO9uYd+lx xnN3PWS6LOIhJoy5/qBwwzJGxJaLBbTkT5bNrvojJajxHtQdXTSauzZAJ4x8kh13zZurSZGKevQ == X-Received: by 2002:a5d:6551:0:b0:236:8fa1:47cf with SMTP id z17-20020a5d6551000000b002368fa147cfmr4255219wrv.50.1668771241100; Fri, 18 Nov 2022 03:34:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf6Ipx2b2LfPxNK3jEsnqNWEXPG0xNNMeZ4wavMmVKV36z9U3XtO3YvYlPzJDYyOsvYTo+Sf9w== X-Received: by 2002:a5d:6551:0:b0:236:8fa1:47cf with SMTP id z17-20020a5d6551000000b002368fa147cfmr4255200wrv.50.1668771240793; Fri, 18 Nov 2022 03:34:00 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id l18-20020a05600c4f1200b003c6f3f6675bsm9405286wmq.26.2022.11.18.03.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Nov 2022 03:34:00 -0800 (PST) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 6/8] gdbserver: use current_process in ps_getpid In-Reply-To: <20221117194241.1776125-7-simon.marchi@efficios.com> References: <20221117194241.1776125-1-simon.marchi@efficios.com> <20221117194241.1776125-7-simon.marchi@efficios.com> Date: Fri, 18 Nov 2022 11:33:59 +0000 Message-ID: <87bkp48pjs.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > The following patch ("gdbserver: switch to right process in > find_one_thread") makes it so find_one_thread calls into libthread_db > with a current process but no current thread. This tripped on ps_getpid > using current_thread in order to get the process' pid. Get the pid from > `current_process ()` instead, which removes the need to have a current > thread. Eventually, it would be good to get it from the > gdb_ps_prochandle_t structure, to avoid the need for a current process > as well. LGTM. Reviewed-By: Andrew Burgess Thanks, Andrew > > Change-Id: I9d2fae266419199a2fbc2fde0a5104c6e0dbd2d5 > --- > gdbserver/proc-service.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdbserver/proc-service.cc b/gdbserver/proc-service.cc > index a49e2b25a47..f86c0e99923 100644 > --- a/gdbserver/proc-service.cc > +++ b/gdbserver/proc-service.cc > @@ -158,5 +158,5 @@ ps_lsetfpregs (gdb_ps_prochandle_t ph, lwpid_t lwpid, const prfpregset_t *fpregs > pid_t > ps_getpid (gdb_ps_prochandle_t ph) > { > - return pid_of (current_thread); > + return current_process ()->pid; > } > -- > 2.37.3