From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id AF63C395BC4D for ; Wed, 16 Nov 2022 17:31:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AF63C395BC4D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 4EBAA1004563D for ; Wed, 16 Nov 2022 17:30:53 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id vMFRoYuYtjKFBvMFRopEoB; Wed, 16 Nov 2022 17:30:53 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=QtabYX+d c=1 sm=1 tr=0 ts=63751e4d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=5OmC6ytFtEmRhBSOe5IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XeniuSu45B8qUQaVz6kIITjXfACZ8flIDX9P8yLFrLU=; b=mWxbkUre+rTj652uKzs2gBcXgO jmWLKnMlrQNM19qWf/csICJ7fHOwkd1SRtir9OW1vEXdQJPzZ+6sMeWsaJo55J2UxJqMlKJJSDKyg LDt7cHd4KEq30o9NnhFPyqpFK; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56856 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1ovMFQ-003YVk-Ou; Wed, 16 Nov 2022 10:30:52 -0700 From: Tom Tromey To: Rainer Orth Cc: gdb-patches@sourceware.org, Luis Machado Subject: Re: [PATCH] Fix various procfs.c compilation errors References: X-Attribution: Tom Date: Wed, 16 Nov 2022 10:30:50 -0700 In-Reply-To: (Rainer Orth's message of "Wed, 16 Nov 2022 16:02:47 +0100") Message-ID: <87bkp6u7qt.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1ovMFQ-003YVk-Ou X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56856 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Rainer" == Rainer Orth writes: Rainer> procfs.c has accumulated several compilation errors lately (some of them Rainer> new with GCC 12), which are fixed by this patch: Thank you. Rainer> It seems that this is another case of GCC PR middle-end/88059, which Rainer> Martin Sebor refuses to fix. So I'm using the hack suggested in the Rainer> PR to use memcpy instead of strncpy. FWIW it's also fine to change this code to use std::string, which is probably both simpler to understand and will avoid warnings. Up to you though. Tom