From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 1A7F13858D32 for ; Tue, 18 Oct 2022 16:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1A7F13858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 34B6310046C60 for ; Tue, 18 Oct 2022 16:29:59 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id kpTaowNvmT2g2kpTaoNc3P; Tue, 18 Oct 2022 16:29:59 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Pds6Ogtd c=1 sm=1 tr=0 ts=634ed487 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=Qawa6l4ZSaYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=CCpqsmhAAAAA:8 a=CwcXT2g0dR-n6KRy-zAA:9 a=bKdfoM6u9_EA:10:demote_shortener_3 a=66zSKFQpzMcA:10:demote_shortener_domain_2 a=4G6NA9xxw8l3yy4pmD5M:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=S9466MUk+Nb17E9mb2cgM7GxqGKCdHTSQ5WZeWpB6mw=; b=WTi1Csp5CXFV7xWBAdlE+K9KlV UDFsffZonYZEZcu8E5MwanfbsMf/NzkH+Sy4qOfRqOUA99vTZlUJnFCW10KqFaxIje9KZ+NPrbmxW BjgwxcjIL9iVU09JHv46pAEzK; Received: from 71-211-181-169.hlrn.qwest.net ([71.211.181.169]:56698 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1okpTZ-003oi5-Q6; Tue, 18 Oct 2022 10:29:57 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Remove dead code from py-finishbreakpoint.c References: <20220605162904.1602810-1-tom@tromey.com> X-Attribution: Tom Date: Tue, 18 Oct 2022 10:29:52 -0600 In-Reply-To: <20220605162904.1602810-1-tom@tromey.com> (Tom Tromey's message of "Sun, 5 Jun 2022 10:29:04 -0600") Message-ID: <87bkq9hz7j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.181.169 X-Source-L: No X-Exim-ID: 1okpTZ-003oi5-Q6 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-181-169.hlrn.qwest.net (murgatroyd) [71.211.181.169]:56698 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2022 16:30:14 -0000 >>>>> "Tom" == Tom Tromey writes: Tom> PR python/16324 points out that comparing a frame id to null_frame_id Tom> can never succeed, and proposes simply removing the dead code. That Tom> is what this patch does. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=16324 I forgot about this patch, but stumbled across the bug today. I've rebased it and fixed it up, and now I'm checking it in. Tom