Re: [PATCH] Improve GDB's baseclass detection with typedefs

[Tom Tromey <tom@tromey.com>]

>>>>> "Bruno" == Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> writes:

Bruno> When a class inherits from a typedef'd baseclass, GDB may be unable to
Bruno> find the baseclass if the user is not using the typedef'd name, as is
Bruno> tested on gdb.cp/virtbase2.exp; the reason that test case is working
Bruno> under gcc is that the dwarf generated by gcc links the class to the
Bruno> original definition of the baseclass, not to the typedef.  If the
Bruno> inheritance is linked to the typedef, such as how clang does it,
Bruno> gdb.cp/virtbase2.exp starts failing.

Bruno> This can also be seen in gdb.cp/impl-this.exp, when attempting to print
Bruno> D::Bint::i, and GDB not being able to find the baseclass Bint.

Bruno> This happens because searching for baseclasses only uses the macro
Bruno> TYPE_BASECLASS_NAME, which returns the typedef'd name. However, we can't
Bruno> switch that macro to checking for typedefs, otherwise we wouldn't be
Bruno> able to find the typedef'd name anymore. This is fixed by searching for
Bruno> members or baseclasses by name, we check both the saved name and the
Bruno> name after checking for typedefs.

Bruno> This also fixes said long-standing bug in gdb.cp/impl-this.exp when the
Bruno> compiler adds information about typedefs in the debuginfo.

Thank you for the patch.  This is ok.

Tom