From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-761.bluehost.com (outbound-ss-761.bluehost.com [74.220.211.250]) by sourceware.org (Postfix) with ESMTPS id BF8AC3857351 for ; Thu, 29 Sep 2022 17:54:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BF8AC3857351 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway8.mail.pro1.eigbox.com (Postfix) with ESMTP id 314071004C13B for ; Thu, 29 Sep 2022 17:54:08 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id dxjboqNrsULMNdxjboaX3p; Thu, 29 Sep 2022 17:54:08 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=UNAYoATy c=1 sm=1 tr=0 ts=6335dbc0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=xOM3xZuef0cA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=hndiNyrCmago1_xsXo8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=m1D4pE7+KSIitylLWiSVAGmsIn9vIjIY7nDI9v0htQw=; b=hhvlCW8mjUiP3BnXHdNIl9CKUy 38C71AeolwDrGga6RwbNI2U7vZgk9UXOmA8ZtYKyfcFavvmVxohjJc/e/DdudECiEv3p9f4/5B9YI NW42tuxESXUTEguka8n1hg3a+; Received: from 71-211-160-49.hlrn.qwest.net ([71.211.160.49]:56590 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1odxja-003wdm-HT; Thu, 29 Sep 2022 11:54:06 -0600 From: Tom Tromey To: Bruno Larsen via Gdb-patches Subject: Re: [PATCH] Improve GDB's baseclass detection with typedefs References: <20220929071418.2621404-1-blarsen@redhat.com> X-Attribution: Tom Date: Thu, 29 Sep 2022 11:54:01 -0600 In-Reply-To: <20220929071418.2621404-1-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Thu, 29 Sep 2022 09:14:18 +0200") Message-ID: <87bkqyxe12.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.160.49 X-Source-L: No X-Exim-ID: 1odxja-003wdm-HT X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-160-49.hlrn.qwest.net (murgatroyd) [71.211.160.49]:56590 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 17:54:23 -0000 >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> When a class inherits from a typedef'd baseclass, GDB may be unable to Bruno> find the baseclass if the user is not using the typedef'd name, as is Bruno> tested on gdb.cp/virtbase2.exp; the reason that test case is working Bruno> under gcc is that the dwarf generated by gcc links the class to the Bruno> original definition of the baseclass, not to the typedef. If the Bruno> inheritance is linked to the typedef, such as how clang does it, Bruno> gdb.cp/virtbase2.exp starts failing. Bruno> This can also be seen in gdb.cp/impl-this.exp, when attempting to print Bruno> D::Bint::i, and GDB not being able to find the baseclass Bint. Bruno> This happens because searching for baseclasses only uses the macro Bruno> TYPE_BASECLASS_NAME, which returns the typedef'd name. However, we can't Bruno> switch that macro to checking for typedefs, otherwise we wouldn't be Bruno> able to find the typedef'd name anymore. This is fixed by searching for Bruno> members or baseclasses by name, we check both the saved name and the Bruno> name after checking for typedefs. Bruno> This also fixes said long-standing bug in gdb.cp/impl-this.exp when the Bruno> compiler adds information about typedefs in the debuginfo. Thank you for the patch. This is ok. Tom