From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 3E4B03858D28 for ; Mon, 18 Jul 2022 17:02:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3E4B03858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 7B8D4100525EA for ; Mon, 18 Jul 2022 17:02:07 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id DU8EodETqCokGDU8EoN3kq; Mon, 18 Jul 2022 17:02:07 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=d+QwdTvE c=1 sm=1 tr=0 ts=62d5920f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RgO8CyIxsXoA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=kudiOJwQc22XEaiPbeEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=msI0AlsW0W/oQMl5ul8YG5wZy8juLPaBU3UANw/N2Og=; b=OmstN+meIjqvgW6YVC7yyAF3xW gNd4b2Drlb4R4Bc5IYH7vz89WmNskARR0qjFbtNefMXbr92QVzPhMdkeTxLF+1qXwFf5DtGwNaY5t qA5/yJvBiR7hp/e9uzT3+o8kL; Received: from 71-211-185-228.hlrn.qwest.net ([71.211.185.228]:56158 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oDU8E-00135e-CE; Mon, 18 Jul 2022 11:02:06 -0600 From: Tom Tromey To: Markus Metzger via Gdb-patches Subject: Re: [PATCH v5 09/15] gdb, ada: update ada_lookup_simple_minsym References: <20220602132514.957983-1-markus.t.metzger@intel.com> <20220602132514.957983-10-markus.t.metzger@intel.com> X-Attribution: Tom Date: Mon, 18 Jul 2022 11:02:04 -0600 In-Reply-To: <20220602132514.957983-10-markus.t.metzger@intel.com> (Markus Metzger via Gdb-patches's message of "Thu, 2 Jun 2022 15:25:08 +0200") Message-ID: <87bktml5gz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.185.228 X-Source-L: No X-Exim-ID: 1oDU8E-00135e-CE X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-185-228.hlrn.qwest.net (murgatroyd) [71.211.185.228]:56158 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3028.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 17:02:22 -0000 >>>>> "Markus" == Markus Metzger via Gdb-patches writes: Markus> Iterate over objfile in search order using the objfile of the context Markus> block as current_objfile so the iteration can stay inside the block's Markus> linker namespace. Markus> diff --git a/gdb/ada-exp.y b/gdb/ada-exp.y Markus> index 8660205809a..85569b841eb 100644 Markus> --- a/gdb/ada-exp.y Markus> +++ b/gdb/ada-exp.y Markus> @@ -1700,8 +1700,15 @@ write_var_or_type (struct parser_state *par_state, Markus> } Markus> else if (syms.empty ()) Markus> { Markus> + if (block == nullptr) Markus> + block = get_selected_block (nullptr); I don't think 'block' can be null here, since it's handled at the top of the function: if (block == NULL) block = par_state->expression_context_block; Tom