From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E3C1F3858407 for ; Mon, 11 Jul 2022 15:38:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3C1F3858407 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-10-AK6RaxSPNSmqgbw16EAVqw-1; Mon, 11 Jul 2022 11:38:51 -0400 X-MC-Unique: AK6RaxSPNSmqgbw16EAVqw-1 Received: by mail-wm1-f69.google.com with SMTP id k16-20020a7bc310000000b0038e6cf00439so2774456wmj.0 for ; Mon, 11 Jul 2022 08:38:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=8t9CfJTh6QUcSCd4EG1W3dka6hoG2UUgJa+Be8BPI78=; b=TwHpjnoVor81t0ZS/bZKWGhJqXcC14BSc8Eomab5z+G975wNVeC5J2JgWk9dupa+VK kDXYMleD1hgcZMfgyY/hCx6wzwmwC+BcUdP9rnBp97d/CQ5MD41aV53EU1fRLfMDRWZf FKjSj29PLo7FZfXjhu4rhqxcdpILXz30NKwMbsn4yamEhiQNQnI7bCaQmjrUx/xkvgux 2yFKN+iOnOGE05dkGzUcIE0fT//Nv1FOC9qGVFalFVDaON0skvYd7E3607+JD3oC3d7g u+M4MHj5tVxr2aBOVH3405tDteoAoD5w3xEwJTiOCFRA75yakXvDMkI/n1X/kDICD03O Sszg== X-Gm-Message-State: AJIora+oo9dXL05KlxOeEM4vMAAXINZqDX761wxKx2+z8VX+0xFfm4pA KAduEQbdVqVxByxnJ4STbFoDaudyiTPe7Cc+47tjsBqcGQVz2a1eIMyOvIkr0DaujSzs128IAa0 C/6hJwiE3fgajW+5YfZX+VA== X-Received: by 2002:a5d:6b0e:0:b0:21d:7886:f4ba with SMTP id v14-20020a5d6b0e000000b0021d7886f4bamr17453580wrw.91.1657553930006; Mon, 11 Jul 2022 08:38:50 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sdIFi9rghi9w0Fpb57QYtIh84adTWSx4O1cJRv9pjdcmMMt0MPquveJUWZ+YiS3vb/Cx3GNQ== X-Received: by 2002:a5d:6b0e:0:b0:21d:7886:f4ba with SMTP id v14-20020a5d6b0e000000b0021d7886f4bamr17453567wrw.91.1657553929838; Mon, 11 Jul 2022 08:38:49 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id b17-20020adff911000000b0021d819c8f6dsm6017295wrr.39.2022.07.11.08.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jul 2022 08:38:49 -0700 (PDT) From: Andrew Burgess To: Enze Li , gdb-patches@sourceware.org Subject: Re: [PATCH] gdbserver: remove unused variable In-Reply-To: References: Date: Mon, 11 Jul 2022 16:38:47 +0100 Message-ID: <87bktvu0ag.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2022 15:38:55 -0000 Enze Li via Gdb-patches writes: > When building with clang 15, I got this error: > > CXX server.o > server.cc:2985:10: error: variable 'new_argc' set but not used [-Werror,-Wunused-but-set-variable] > int i, new_argc; > ^ > Remove the unused variable to eliminate the error. LGTM. Please apply it. Thanks, Andrew > > Tested by rebuilding on x86_64-linux with clang 15. > --- > gdbserver/server.cc | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/gdbserver/server.cc b/gdbserver/server.cc > index f9c02a9c6dac..c619206d5d2d 100644 > --- a/gdbserver/server.cc > +++ b/gdbserver/server.cc > @@ -2982,14 +2982,10 @@ handle_v_run (char *own_buf) > char *p, *next_p; > std::vector new_argv; > char *new_program_name = NULL; > - int i, new_argc; > + int i; > > - new_argc = 0; > for (p = own_buf + strlen ("vRun;"); p && *p; p = strchr (p, ';')) > - { > - p++; > - new_argc++; > - } > + p++; > > for (i = 0, p = own_buf + strlen ("vRun;"); *p; p = next_p, ++i) > { > -- > 2.30.2