From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id C33C2382F984 for ; Fri, 20 May 2022 16:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C33C2382F984 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 2FA2210046B29 for ; Fri, 20 May 2022 16:00:24 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id s538nbuT2Qs3Cs538neJn1; Fri, 20 May 2022 16:00:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=A+Opg4aG c=1 sm=1 tr=0 ts=6287bb17 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=Xvg9jJmmZ0ZjUeVVCbQA:9 a=DvZ5ixILWSEuw56YIEpp:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cNufVKxBRx8rspdoLxncAyrwlNvM4uFJn1oGWoWq57I=; b=STKfo1LyWSIod0ppxfYj3iNFIC L9IJkmwvWYjCqR1eElBNn6ytSv3uChzBEzsFxasw+8XVzeal18VQjhNJh/rPBOgKlE9bUbFElCKjJ kw2c2n2akWQy5UO48fqI+ulGB; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55816 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ns538-003wyP-5n; Fri, 20 May 2022 10:00:22 -0600 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 20/23] Momentary breakpoints should have no breakpoint number References: <20220516184030.665489-1-pedro@palves.net> <20220516184030.665489-21-pedro@palves.net> X-Attribution: Tom Date: Fri, 20 May 2022 10:00:20 -0600 In-Reply-To: <20220516184030.665489-21-pedro@palves.net> (Pedro Alves's message of "Mon, 16 May 2022 19:40:27 +0100") Message-ID: <87bkvsb3e3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1ns538-003wyP-5n X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55816 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2022 16:00:26 -0000 >>>>> "Pedro" == Pedro Alves writes: Pedro> Momentary breakpoints have no breakpoint number, their breakpoint Pedro> number should be always 0, to avoid constantly incrementing (or Pedro> decrementing) the internal breakpoint count. Pedro> Indeed, set_momentary_breakpoint installs the created breakpoint Pedro> without a number. Pedro> However, momentary_breakpoint_from_master incorrectly gives an Pedro> internal breakpoint number to the new breakpoint. This commit fixes Pedro> that. I think it would probably be good to document this somewhere. Like, maybe the deleted line could be replaced with a comment. Tom