From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 569193858C83 for ; Tue, 26 Apr 2022 18:54:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 569193858C83 Received: by mail-io1-xd2d.google.com with SMTP id c125so21430565iof.9 for ; Tue, 26 Apr 2022 11:54:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=3h7d1zTmLXz0HdxGy2t6A4150/zM0TWndyVwQDcjGiI=; b=aKP1+KscJI7N8z/RdtpiJOU4nKIMXcAUKIx0mNVN46hX49Bnd3Y/O5lx04vfK1fvQC H24ChWCR5KmKujLZ7ZP1LVSDAl9j+yYLVA4lLYGQyDMydAGeGA9g9RPrplt+c4ecNOqN pZ7xlewyW4BMq280lNsoesE3tJ2jsVP3Gc5gPPSuX+wy0D8rZFn4SkaIOH8fZPe62UWj 9SqoPktlNe7Gzlmfj89SoeGSwEAxLo/LOlfvjTQxo/Z+/0Y5hFHqVr961yD0THmvVVrh nRgie09sMbDBvScXOAOZwahVQQIC8n6s8/UEeo13eON1LSbluayP89PVONBRKdFhV8Hz DEYA== X-Gm-Message-State: AOAM532z3cym/D6ys08iSx4xhHJyIkoaERoQvYJ/0XyH6rq1YoBUsl0L dtcP9eCCJctRHA7tfmbXM9LFfQ== X-Google-Smtp-Source: ABdhPJysgKa64Rrg1gG9RGk/Fs12xxcqMlXte3xH5VMNW8w4yQG/6SuGnKOV789b1NZDt1G8OkXASA== X-Received: by 2002:a05:6638:2501:b0:32b:b8e:634d with SMTP id v1-20020a056638250100b0032b0b8e634dmr1382850jat.281.1650999240373; Tue, 26 Apr 2022 11:54:00 -0700 (PDT) Received: from murgatroyd (71-211-158-194.hlrn.qwest.net. [71.211.158.194]) by smtp.gmail.com with ESMTPSA id n23-20020a6b8b17000000b00649a2634725sm9009919iod.17.2022.04.26.11.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 11:53:59 -0700 (PDT) From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Handle encoding failures in Windows thread names References: <20220421143926.2550856-1-tromey@adacore.com> <83r15qqvz6.fsf@gnu.org> X-Attribution: Tom Date: Tue, 26 Apr 2022 12:53:59 -0600 In-Reply-To: <83r15qqvz6.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 21 Apr 2022 18:47:41 +0300") Message-ID: <87bkwnoeuw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 18:54:02 -0000 Eli> I suggest to explain in a comment how this code detects encoding Eli> failures. The documentation of WideCharToMultiByte is not simple to Eli> understand in this regard, and "used_default" is not expressive enough Eli> to explain its role here, so I suggest not to rely on the reader to Eli> know those subtleties. I've added a comment and I'm checking this in. Tom