Re: [PATCH v2] gdb/Python: Added ThreadExitedEvent

[Tom Tromey <tom@tromey.com>]

>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> Currently no event is emitted for a thread exit.
Simon> This adds this functionality by emitting a new gdb.ThreadExitedEvent.

Simon> It currently provides three attributes, the LWP id, the TID and
Simon> the GLOBAL NUM. A case could be made to also add the per-inferior
Simon> number, but, I wasn't sure if it is actually any useful.

Simon> Added info to docs & the NEWS file as well.

Eli will have to review the docs, unless he already has.

Simon> +  if (!evregpy_no_listeners_p (gdb_py_events.thread_exited))
Simon> +    {
Simon> +      ptid_t ptid = tmp->thread_obj->thread->ptid;
Simon> +      int global_num = tmp->thread_obj->thread->global_num;
Simon> +      if (emit_thread_exit_event (ptid, global_num) < 0)
Simon> +	gdbpy_print_stack();

Space before open paren here.

Simon> +emit_thread_exit_event (ptid_t ptid, int global_num)
Simon> +{
Simon> +  gdbpy_ref<> thread_event_obj = create_event_object (&thread_exited_event_object_type);
Simon> +  if (thread_event_obj == NULL)

We're using 'nullptr' in new code.

I'm curious why the event has various attributes of the thread object
but not a reference to the thread object itself.  That seems a little
odd.

Simon> +    append GDBFLAGS " -ex \"set non-stop on\""

Is this really needed?

Otherwise, this patch looks good.  Thank you for doing this.

Tom