From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 169453858405 for ; Wed, 30 Mar 2022 09:13:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 169453858405 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-402-E-t3rMRaMHmDRzdDXQo11Q-1; Wed, 30 Mar 2022 05:13:41 -0400 X-MC-Unique: E-t3rMRaMHmDRzdDXQo11Q-1 Received: by mail-wm1-f72.google.com with SMTP id 4-20020a05600c274400b0038c8ab2e835so2355333wmw.1 for ; Wed, 30 Mar 2022 02:13:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=KgOfB7+mFBeROHQplN3r8wZmT3uzI6hNznfLDjB51ZA=; b=ADxpUbwpovkEieENuNGuqTd8X9fgflMUO5YoteDpEdmVt9aYtG+Afj4WX9s2u4gUIZ LhT16+/Z5eI8qvRaqc45RBavLtMM9tIMlEFb/QrkMFuwIXRVG7cbQJqiiKXwYEOlQ+K6 UokGFnheJ28/8iIe4DMkjsW7kBFcpd68SJuiilc2z+hiQ9aJ2WbLkP++bTW/fdg8Jopn EsP0bU0+UcuZMP5j8keIYMMOo5VREUFs/c1JJQkce3Apjm+hdPwfqre51L43EjRCXsAh DfwwyZBTkGMsNob2aT0IzGx0Mskaf+YN9kCQkQq027pbRi7DIh9WzDgOve3WvGzFTMtF h0RA== X-Gm-Message-State: AOAM531ukcF1I9jxg5w91YBwhjEL7TVaaIFhJjZclbsxNHnQtAMXzuTU AWvLoJr96JZzfxT0S/TLoGUfTulLplvdfODy9FgRh+NyMwWPK3LR9NJhKPrnDl5pBczmGt58TIL Co7toXs/rZMWBiUeYT94fn7O0dXMQY+vRwSFtoBNilZK3SYGgPMOtUvsGEsgSi0Rgoy7my9SEdw == X-Received: by 2002:a05:600c:4e93:b0:38c:92d9:c7bc with SMTP id f19-20020a05600c4e9300b0038c92d9c7bcmr3412901wmq.173.1648631619794; Wed, 30 Mar 2022 02:13:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRu91UbapFO0ik7dpzBFLC4gq/c8PpuU+Ic/zcTaq5/cgHAnVs9A94A6ZiUjBVB3NZQzlsOQ== X-Received: by 2002:a05:600c:4e93:b0:38c:92d9:c7bc with SMTP id f19-20020a05600c4e9300b0038c92d9c7bcmr3412883wmq.173.1648631619484; Wed, 30 Mar 2022 02:13:39 -0700 (PDT) Received: from localhost (host86-169-131-113.range86-169.btcentralplus.com. [86.169.131.113]) by smtp.gmail.com with ESMTPSA id m3-20020a5d6243000000b001e33760776fsm16829372wrv.10.2022.03.30.02.13.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 02:13:38 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: Re: [PATCHv3 00/15] TUI changes, new winwidth command and resizing changes In-Reply-To: <87y213ry5l.fsf@redhat.com> References: <87y213ry5l.fsf@redhat.com> Date: Wed, 30 Mar 2022 10:13:37 +0100 Message-ID: <87bkxnajlq.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 09:13:45 -0000 I'm planning to push this series soon(ish) unless someone complains. The only series comments on v2 were for patch #5, which I believe are now addressed. As always, if there's any feedback post-commit, I'm happy to address issues as they are raised. Thanks, Andrew Andrew Burgess writes: > Ping! > > Thanks, > Andrew > > > Andrew Burgess writes: > >> Since v2: >> >> - Rebased onto current upstream/master, >> >> - Patch #5 - Rewritten to not use templates! >> >> - Patch #6 - Added a bug in bugzilla, and referenced this from the >> commit message, >> >> - Patch #7 - Renamed the existing methods rather than adding 2 new >> methods, >> >> - Patch #10 - Updated the comment Tom identified as being out of >> date, >> >> - Patch #15 - Have updated a comment that I spotted was out of date. >> >> Thanks, >> Andrew >> >> >> --- >> >> Andrew Burgess (15): >> gdb: move some commands into the tui namespace >> gdb/tui: rename tui_layout_base::adjust_size to ::set_height >> gdb/tui: rename tui_layout_split:set_weights_from_heights >> gdb/testing/tui: add new functionality to tuiterm.exp >> gdb/tui: add new 'tui window width' command and 'winwidth' alias >> gdb/tui: add a tui debugging flag >> gdb/tui: add left_boxed_p and right_boxed_p member functions >> gdb/tui/testsuite: refactor new-layout.exp test >> gdb/tui: avoid fp exception when applying layouts >> gdb/tui: fairer distribution of excess space during apply >> gdb/tui: allow cmd window to change size in tui_layout_split::apply >> gdb/tui: support placing the cmd window into a horizontal layout >> gdb/testsuite: some additional tests in gdb.tui/scroll.exp >> gdb/tui: relax restrictions on window max height and width >> gdb/tui: fair split of delta after a resize >> >> gdb/NEWS | 25 ++ >> gdb/doc/gdb.texinfo | 51 +++- >> gdb/testsuite/gdb.tui/basic.exp | 4 +- >> gdb/testsuite/gdb.tui/empty.exp | 14 +- >> gdb/testsuite/gdb.tui/new-layout.exp | 100 +++++-- >> gdb/testsuite/gdb.tui/regs.exp | 4 +- >> gdb/testsuite/gdb.tui/scroll.exp | 4 + >> gdb/testsuite/gdb.tui/winheight.exp | 77 +++++ >> gdb/testsuite/gdb.tui/winwidth.exp | 63 +++++ >> gdb/testsuite/lib/tuiterm.exp | 82 +++++- >> gdb/tui/tui-command.c | 6 - >> gdb/tui/tui-command.h | 2 - >> gdb/tui/tui-layout.c | 406 ++++++++++++++++++++++----- >> gdb/tui/tui-layout.h | 135 +++++++-- >> gdb/tui/tui-win.c | 118 ++++++-- >> gdb/tui/tui.c | 26 ++ >> gdb/tui/tui.h | 14 + >> 17 files changed, 971 insertions(+), 160 deletions(-) >> create mode 100644 gdb/testsuite/gdb.tui/winwidth.exp >> >> -- >> 2.25.4