From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2d.google.com (mail-io1-xd2d.google.com [IPv6:2607:f8b0:4864:20::d2d]) by sourceware.org (Postfix) with ESMTPS id 583023858D3C for ; Fri, 18 Mar 2022 17:00:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 583023858D3C Received: by mail-io1-xd2d.google.com with SMTP id r11so9925636ioh.10 for ; Fri, 18 Mar 2022 10:00:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=9vDICKv62PifImcu65d4lkgQaUq2DSq3CErB57J9cR0=; b=J16wz8iSw6ZE8+NZ7UDfle3owHAM+OgyUxHnuc5e2kRVK1wFdDc0ymVbA6QHkNNo2v AvDSZPbqIvzpkeoQvHSTUd0bxUKconGmwAMahaHutF/JO+Lcg2ed19eVhzQIJszidkqE GkuEHdhvyXZHy7d9gYhWz3b4WKDNeNhejKUsPtosepF+dKe2QBj4dMlR1MgECbSqgK6X 9+pCC2Pl3HL7dRE/r7jUK/uW3rfZ1O3rO+v4Sry54uSAQU8gMeET0QbjBWiDAr7oxhpy ceEAL4DN0xvp+mHcCuyw2nOhAWcwvD+Bw8cOuQUsECUOQQqaOB7ZfH30Z0q1o8fh+Xhj Km6g== X-Gm-Message-State: AOAM531SXgZW/KW3dTesCvCV7CGwD7K2wsxpeaCmCk2Pr7FGXBs0xtSW 6YtP8k1IX4p6bVCHpmbZJE16Gw== X-Google-Smtp-Source: ABdhPJxK6XiltTsWpvTJ/H+nAxFUpku4XPUNQdQE3x8Aa3XX2POpYH0NP7TFspq7Y7VccxXVs79Q2w== X-Received: by 2002:a05:6638:13c9:b0:317:c419:d89f with SMTP id i9-20020a05663813c900b00317c419d89fmr4535706jaj.190.1647622845361; Fri, 18 Mar 2022 10:00:45 -0700 (PDT) Received: from murgatroyd (71-211-175-224.hlrn.qwest.net. [71.211.175.224]) by smtp.gmail.com with ESMTPSA id x10-20020a056e021caa00b002c7e9389127sm2988040ill.84.2022.03.18.10.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Mar 2022 10:00:44 -0700 (PDT) From: Tom Tromey To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Implement gdbarch_stack_frame_destroyed_p for aarch64 References: <20220311163133.668809-1-tromey@adacore.com> <00c20109-0a0c-b70c-a962-5a64539cc43a@arm.com> <87ee34lla9.fsf@tromey.com> <60f230a4-77b7-0a97-2f80-a2caa7a6f4a1@arm.com> X-Attribution: Tom Date: Fri, 18 Mar 2022 11:00:43 -0600 In-Reply-To: <60f230a4-77b7-0a97-2f80-a2caa7a6f4a1@arm.com> (Luis Machado's message of "Mon, 14 Mar 2022 13:41:08 +0000") Message-ID: <87bky3i4as.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 17:00:47 -0000 >> I didn't dig quite this deep but I think it's different memory >> contents >> in the caller's stack frame. Luis> The kind of which will change from run to run, not triggering the Luis> watchpoint in some cases? Yeah. I didn't really look into that part too much. Luis> Yeah. Anyway, other backends rely on this hook as well. So the patch Luis> is fine to me. As I've said before, I didn't see any regressions. Thank you, I'm going to check it in. Tom