From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 155CA3858D3C for ; Fri, 11 Mar 2022 14:51:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 155CA3858D3C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 6AB891004851E for ; Fri, 11 Mar 2022 14:51:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id SgblnOUHYY8ycSgbmn0Oxl; Fri, 11 Mar 2022 14:51:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ue6U9IeN c=1 sm=1 tr=0 ts=622b61de a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=66eg5_bXqjwD8cNg458A:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3E/1YbVajJv4N0pJ4+UrvwFaAU8gBFurSfjO9OuE4bo=; b=rc/1tJxxTD5EHrdmstld7SCyLd ZRFig3iyeqeI4MgWTsc6/FiAN3JhrDkgpACSuBdNN+gzOkkcQzDfMHyqymOP57v5yL8Hdq0HaILpN VqG55vRR38SJWNQCLYYnwJpTr; Received: from 75-166-141-253.hlrn.qwest.net ([75.166.141.253]:37966 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSgbl-001SvQ-Dt; Fri, 11 Mar 2022 07:51:09 -0700 From: Tom Tromey To: Tiezhu Yang Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] gdb: LoongArch: fix failed testcases in gdb.base/align-c.exp References: <1646740859-28698-1-git-send-email-yangtiezhu@loongson.cn> <1646740859-28698-3-git-send-email-yangtiezhu@loongson.cn> X-Attribution: Tom Date: Fri, 11 Mar 2022 07:51:08 -0700 In-Reply-To: <1646740859-28698-3-git-send-email-yangtiezhu@loongson.cn> (Tiezhu Yang's message of "Tue, 8 Mar 2022 20:00:59 +0800") Message-ID: <87bkycmtk3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.141.253 X-Source-L: No X-Exim-ID: 1nSgbl-001SvQ-Dt X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-141-253.hlrn.qwest.net (murgatroyd) [75.166.141.253]:37966 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 14:51:12 -0000 >>>>> Tiezhu Yang writes: > When execute the following command on LoongArch: > make check-gdb TESTS="gdb.base/align-c.exp" > there exists some failed testcases: > ... > FAIL: gdb.base/align-c.exp: print _Alignof(struct align_pair_long_double_x_float) > FAIL: gdb.base/align-c.exp: print _Alignof(struct align_pair_long_double_x_double) > FAIL: gdb.base/align-c.exp: print _Alignof(struct align_pair_long_double_x_long_double) > ... > According to LoongArch ELF ABI specification [1], set the target data types > of floating-point to fix the above failed testcases. Looks good to me. If you want to reword this to land it before the floatformat renaming, that's also fine. Tom