From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.50.84]) by sourceware.org (Postfix) with ESMTPS id 99C193858D29 for ; Thu, 23 Sep 2021 20:21:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99C193858D29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 264452287 for ; Thu, 23 Sep 2021 15:21:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TVDZmMba5HlR1TVDZmnd1d; Thu, 23 Sep 2021 15:21:17 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TWxpcDed26a/xrPeInmawM3KoPrb2Vyuxg5QEqJUukA=; b=dv4BbUYEcNhPdngm0VI2Nfdc0w W9KJYrHsbX6eiPO0ueWa2a71q0b+32e3NgHyqoqwvNWD0HtKaBhr3b2bUxy0+JM2fp+vSs/6U5mIP oAne0Uh0z/zr236ALLOWZcvx7; Received: from 174-16-0-219.hlrn.qwest.net ([174.16.0.219]:53910 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mTVDY-003Dg5-QM; Thu, 23 Sep 2021 14:21:16 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] gdb: remove duplicate cmd_list_element declarations References: X-Attribution: Tom Date: Thu, 23 Sep 2021 14:21:16 -0600 In-Reply-To: (Andrew Burgess's message of "Wed, 8 Sep 2021 22:34:54 +0100") Message-ID: <87bl4j3uwz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.0.219 X-Source-L: No X-Exim-ID: 1mTVDY-003Dg5-QM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-0-219.hlrn.qwest.net (murgatroyd) [174.16.0.219]:53910 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 20:21:18 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> For some reason we have two locations where cmd_list_elements are Andrew> declared, cli/cli-cmds.h and gdbcmd.h. Worse still there is Andrew> duplication between these two locations. Andrew> In this commit I have moved all of the cmd_list_element declarations Andrew> from gdbcmd.h into cli/cli-cmds.h and removed the duplicates. Thanks for cleaning this up. It looks good to me. Tom