From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/guile: perform tilde expansion when sourcing guile scripts
Date: Wed, 05 May 2021 13:11:37 -0600 [thread overview]
Message-ID: <87bl9pq9li.fsf@tromey.com> (raw)
In-Reply-To: <20210505174058.2135104-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 5 May 2021 18:40:58 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> This is because the path is not tilde expanded. In contrast, when
Andrew> sourcing a .py or .gdb script the path is tilde expanded.
Andrew> This commit fixes this oversight, and allows the above source command
Andrew> to work as expected.
It seems a little strange to me that each extension language must do
this, rather than the caller doing it.
Andrew> + gdb::unique_xmalloc_ptr<char> msg
Andrew> + (gdbscm_safe_source_script (full_path.c_str ()));
I suppose gdbscm_safe_source_script could return a unique_xmalloc_ptr,
and this could just use the '=' form.
Tom
next prev parent reply other threads:[~2021-05-05 19:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 17:40 Andrew Burgess
2021-05-05 19:11 ` Tom Tromey [this message]
2021-05-05 21:01 ` [PATCHv2 0/2] " Andrew Burgess
2021-05-05 21:01 ` [PATCHv2 1/2] " Andrew Burgess
2021-05-06 2:23 ` Simon Marchi
2021-05-07 10:29 ` Andrew Burgess
2021-05-07 14:55 ` Simon Marchi
2021-05-07 21:23 ` Andrew Burgess
2021-05-05 21:01 ` [PATCHv2 2/2] gdb/guile: Have gdbscm_safe_source_script return a unique_ptr Andrew Burgess
2021-05-06 2:28 ` Simon Marchi
2021-05-06 2:32 ` Simon Marchi
2021-05-07 8:55 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl9pq9li.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).