From: Tom Tromey <tom@tromey.com>
To: Christian Biesinger via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,
Christian Biesinger <cbiesinger@google.com>,
Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH 5/8] Turn target_can_execute_reverse into function-like macro
Date: Mon, 28 Sep 2020 19:36:24 -0600 [thread overview]
Message-ID: <87blhpmkiv.fsf@tromey.com> (raw)
In-Reply-To: <CAPTJ0XEWD8-tz7gzk8qw3kpVy0CSfHJ3tO-StG2AGkMGe+G=6w@mail.gmail.com> (Christian Biesinger via Gdb-patches's message of "Tue, 21 Jul 2020 12:07:43 -0500")
>> This changes target_can_execute_reverse from an object-like macro to a
>> function-like macro.
Christian> Since there's only a few callers, and the implementation is simple,
Christian> why not remove the macro and call current_top_target
Christian> ()->can_execute_reverse () directly? That makes this global variable
Christian> access more obvious.
I didn't do this since it isn't the ordinary style here.
I don't know how this API ought to look in the future.
Maybe methods on inferior? Or stay like it is but have the inferior as
an argument?
Simon> Why a macro and not a function here?
In the end I changed the remaining macros to inline functions.
Tom
next prev parent reply other threads:[~2020-09-29 1:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 1:49 [PATCH 0/8] Remove object-like target macros Tom Tromey
2020-07-21 1:49 ` [PATCH 1/8] Remove target_has_all_memory Tom Tromey
2020-07-21 1:49 ` [PATCH 2/8] Remove target_has_memory macro Tom Tromey
2020-07-21 1:49 ` [PATCH 3/8] Remove target_has_stack macro Tom Tromey
2020-07-21 17:12 ` Christian Biesinger
2020-09-29 1:36 ` Tom Tromey
2020-07-21 1:49 ` [PATCH 4/8] Remove target_has_registers macro Tom Tromey
2020-07-21 1:49 ` [PATCH 5/8] Turn target_can_execute_reverse into function-like macro Tom Tromey
2020-07-21 2:30 ` Simon Marchi
2020-07-21 17:07 ` Christian Biesinger
2020-09-29 1:36 ` Tom Tromey [this message]
2020-07-21 1:49 ` [PATCH 6/8] Remove target_has_execution macro Tom Tromey
2020-07-21 1:49 ` [PATCH 7/8] Turn target_can_lock_scheduler into a function-like macro Tom Tromey
2020-07-21 2:32 ` Simon Marchi
2020-07-21 11:28 ` Tom Tromey
2020-09-29 1:37 ` Tom Tromey
2020-07-21 1:49 ` [PATCH 8/8] Turn target_have_steppable_watchpoint into " Tom Tromey
2020-09-29 1:38 ` [PATCH 0/8] Remove object-like target macros Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87blhpmkiv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).