From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway23.websitewelcome.com (gateway23.websitewelcome.com [192.185.50.107]) by sourceware.org (Postfix) with ESMTPS id CEB9C3885C19 for ; Mon, 15 Jun 2020 17:30:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CEB9C3885C19 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway23.websitewelcome.com (Postfix) with ESMTP id 061C5C4FB for ; Mon, 15 Jun 2020 12:30:02 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ksvqjKnYaXGIkksvqjs2Wu; Mon, 15 Jun 2020 12:30:02 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uKkEmqT7XREgFAu2R/Z/Z1ouoz3YdqzyJDsKccGOM7Y=; b=Es7f9JKlRY/qVhOqRKwx8/BiVH yw1/0tnWBWlgGvmGsZdZux49fpzz7dvBVFLs1EfykPS0oGZGTi9EsHUegxbOu6RXTDEPboHrnDdB1 NSnQJPfcUBIcJA1VgfqCvhWeL; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:60292 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1jksvq-001Zv6-CG; Mon, 15 Jun 2020 11:30:02 -0600 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 05/11] Rewrite the existing variant part code References: <20200408175452.30637-1-tromey@adacore.com> <20200408175452.30637-6-tromey@adacore.com> <34e8cada-3ba3-97f4-ed2e-9baa1aad4d58@suse.de> X-Attribution: Tom Date: Mon, 15 Jun 2020 11:30:01 -0600 In-Reply-To: <34e8cada-3ba3-97f4-ed2e-9baa1aad4d58@suse.de> (Tom de Vries's message of "Thu, 4 Jun 2020 10:13:56 +0200") Message-ID: <87bllkkzja.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jksvq-001Zv6-CG X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:60292 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_ABUSEAT, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2020 17:30:06 -0000 >>>>> "Tom" == Tom de Vries writes: Tom> On 08-04-2020 19:54, Tom Tromey wrote: >> This rewrites the existing variant part code to follow the new model >> implemented in the previous patch. The old variant part code is >> removed. >> >> This only affects Rust for the moment. I tested this using various >> version of the Rust compiler, including one that emits old-style enum >> debuginfo, exercising the quirks code. Tom> This causes regressions with target board readnow. I finally looked at this, but I can't reproduce it. Which version of the Rust compiler are you using? Perhaps that makes a difference. thanks, Tom