From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway30.websitewelcome.com (gateway30.websitewelcome.com [192.185.151.58]) by sourceware.org (Postfix) with ESMTPS id DFDBE383F857 for ; Fri, 22 May 2020 19:41:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org DFDBE383F857 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id 89E7B4345 for ; Fri, 22 May 2020 14:41:49 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id cDYDjbQnDVQh0cDYDjeg3r; Fri, 22 May 2020 14:41:49 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HXSrHXVHol0mjMED99oypqykom3TYsnkrUKU1cMIzco=; b=LLHLReRNaJDMyxnSJOVSKaadrn bR1gHnr2uNQ/NbFJ5ywlqJDgulEylndBYiJwkHrysYj9OsznNqWY3bSA5vk4ZGmGuaW7+Vncc/qWC wjd9GaiBEzEAA9xsTxvJizsFN; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:35766 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jcDYD-003Qhi-8s; Fri, 22 May 2020 13:41:49 -0600 From: Tom Tromey To: paul-naert via Gdb-patches Cc: paul-naert Subject: Re: [RFC][PATCH 6/7] Convert short jumps to long ones in amd64_relocate_instruction References: <20200514140849.31845-1-paul_naert@hotmail.fr> <20200514140849.31845-7-paul_naert@hotmail.fr> X-Attribution: Tom Date: Fri, 22 May 2020 13:41:48 -0600 In-Reply-To: <20200514140849.31845-7-paul_naert@hotmail.fr> (paul-naert via Gdb-patches's message of "Thu, 14 May 2020 10:08:48 -0400") Message-ID: <87blmf4v0j.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jcDYD-003Qhi-8s X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:35766 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 May 2020 19:41:51 -0000 >>>>> ">" == paul-naert via Gdb-patches writes: >> + if (newrel < INT32_MIN || newrel > INT32_MAX) >> + { >> + /* Overflowing the 32 bit jump */ >> + if (debug_displaced) >> + error (_ ("Overflowing of int32 for jump instruction relocation")); >> + } It seems like the error ought not be conditional on debug_displaced. Wouldn't this result in silently doing something incorrect? Tom