From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20639 invoked by alias); 18 Feb 2020 21:57:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20561 invoked by uid 89); 18 Feb 2020 21:57:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=faod, FAOD X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.253) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Feb 2020 21:57:25 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 05AFE536F for ; Tue, 18 Feb 2020 15:57:23 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4ArqjxHIUXVkQ4ArqjK9V6; Tue, 18 Feb 2020 15:57:23 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CMYhfJ88/9HTIqNaztfDByDhOwEE6M3w5pc5snaGXek=; b=YL6SRWjL6Ae1EViKLJts4H3bYs cuDulzKikAc2D2Rwvc2INW+Odp9JatKA9swt0xbvSTQmF7cz93o0I4dl+Y1PvN8ANtoSGW8ME1fRG of4MGFv15KNtvMfmVUcSpfFup; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:49294 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j4Arq-002BhZ-OI; Tue, 18 Feb 2020 14:57:22 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 3/5] gdb: allow duplicate enumerators in flag enums References: <20200213203035.30157-1-simon.marchi@efficios.com> <20200213203035.30157-3-simon.marchi@efficios.com> <87a75f7hs7.fsf@tromey.com> <31be9c0a-c389-123b-e2cd-338add47aca2@simark.ca> Date: Tue, 18 Feb 2020 21:57:00 -0000 In-Reply-To: <31be9c0a-c389-123b-e2cd-338add47aca2@simark.ca> (Simon Marchi's message of "Tue, 18 Feb 2020 15:48:34 -0500") Message-ID: <87blpv5zjy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00750.txt.bz2 >>>>> "Simon" == Simon Marchi writes: Simon> Is this list of fields guaranteed to be Simon> in the same order as what's in the code though? Yeah, should be, of course subject to what the compiler decides. Simon> Not sure what you mean here. With the current patch, this enum would not Simon> bne marked as a flag enum, as `one` has multiple bits set. I read the patches in the wrong order. FAOD this one also looks good to me. Tom