From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25603 invoked by alias); 19 Sep 2018 14:49:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25592 invoked by uid 89); 19 Sep 2018 14:49:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=boy, wish X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.85) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 19 Sep 2018 14:49:14 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 61C5E1DF562 for ; Wed, 19 Sep 2018 09:49:12 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2dmcgoOVmbXuJ2dmpg69TJ; Wed, 19 Sep 2018 09:49:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SxSQZsSoRle8OngscScnOF3D0VORN9hGH+MrakRr3Mo=; b=mzgB+rnBIKksAxC3kRxHXbZ+ag iRPgEG8U6VfLv5SpTYotLjn2E3IncdXXC0+iQX4/VFN9BH7vkULC3cfrlYvSGqf/3NqYjLECL6EwT ehRKXLrMNNitXvRX2UTgvbzJZ; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:54990 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g2dmc-002ZJP-5U; Wed, 19 Sep 2018 09:48:50 -0500 From: Tom Tromey To: Rainer Orth Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Provide pid_to_exec_file on Solaris (PR tdep/17903) References: Date: Wed, 19 Sep 2018 14:49:00 -0000 In-Reply-To: (Rainer Orth's message of "Wed, 19 Sep 2018 16:17:57 +0200") Message-ID: <87bm8tr19q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00691.txt.bz2 >>>>> "Rainer" == Rainer Orth writes: Rainer> Tested on amd64-pc-solaris2.10 and amd64-pc-solaris2.11, ok for master? Thank you for doing this. Rainer> + char *pid_to_exec_file (int pid) override; Boy this is a bad API! Not your problem but I'll make a note on my to-do list to change it to return a std::string or something like that. Rainer> + scoped_fd fd (open (name, O_RDONLY)); You may wish to use gdb_open_cloexec. procfs.c is one of the cloexec holdouts, because I could never compile it. But I guess once the buildbot is up I can do it :) Tom