public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: GDB 8.2 branch 2018-06-11 Update
Date: Fri, 22 Jun 2018 20:37:00 -0000	[thread overview]
Message-ID: <87bmc24kya.fsf@tromey.com> (raw)
In-Reply-To: <20180622142146.GA3143@adacore.com> (Joel Brobecker's message of	"Fri, 22 Jun 2018 10:21:46 -0400")

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> I'm hesitating on that one. Personally, I would accept the patch without
Joel> a testcase based on it being trivial; but on the other hand, it seems
Joel> worth giving the testcase a reasonable try, as I am hoping it might not
Joel> be an unreasonable amount of work to create it, and although the fix is
Joel> trivial, we did introduce that regression, so it's something that can
Joel> happen if we continue without a testcase.

I'll try to write a test next week.

Tom

      reply	other threads:[~2018-06-22 20:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-11 22:56 Joel Brobecker
2018-06-12  0:19 ` Sergio Durigan Junior
2018-06-12  8:29 ` Alan Hayward
2018-06-12 12:59   ` Simon Marchi
2018-06-12 21:57 ` Philippe Waroquiers
2018-06-19  6:07 ` Tom Tromey
2018-06-22 14:21   ` Joel Brobecker
2018-06-22 20:37     ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bmc24kya.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).