From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 38161 invoked by alias); 14 Jun 2018 15:42:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 38151 invoked by uid 89); 14 Jun 2018 15:42:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:795 X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.80) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 14 Jun 2018 15:42:36 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id DD377E2E526 for ; Thu, 14 Jun 2018 10:42:33 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id TUOCfN1JvPvAdTUOKfYSZz; Thu, 14 Jun 2018 10:42:33 -0500 X-Authority-Reason: nr=8 Received: from [12.176.89.6] (port=35096 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fTUOB-000tJB-OZ; Thu, 14 Jun 2018 10:42:20 -0500 From: Tom Tromey To: Pedro Alves Cc: Simon Marchi , Joel Brobecker , Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 00/10] Remove standalone ptid functions References: <20180613215049.9691-1-tom@tromey.com> <20180613232228.GA2166@adacore.com> <49903166aff66528df83fbda26001be8@polymtl.ca> <64e82c8f-9647-2fb9-62f7-0b31660a41c6@redhat.com> Date: Thu, 14 Jun 2018 15:42:00 -0000 In-Reply-To: <64e82c8f-9647-2fb9-62f7-0b31660a41c6@redhat.com> (Pedro Alves's message of "Thu, 14 Jun 2018 12:06:27 +0100") Message-ID: <87bmcde5nq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fTUOB-000tJB-OZ X-Source-Sender: (pokyo) [12.176.89.6]:35096 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00362.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I'm just not so sure about eliminating pid_to_ptid. I'd ran into uses Pedro> of that where I had second thoughts on whether replacing it with Pedro> a ptid_t ctor call is really a good idea. What I thought was, Pedro> that when you're reading the code, a pid_to_ptid call more clearly shows Pedro> that want to build a process-wide (sometimes a filter) ptid as opposed Pedro> to a single thread ptid. It also helps with grepping, if you'd like Pedro> to find such spots. But it's not a big deal, and I can certainly live Pedro> with it. It's easy enough to drop it out of the series if you would prefer that, or to rename it to something like ptid_t::from_pid. Let me know. Tom