From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106901 invoked by alias); 4 May 2018 18:47:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106891 invoked by uid 89); 4 May 2018 18:47:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=stood, 2018-04-21, 20180421, Hx-languages-length:881 X-HELO: gateway36.websitewelcome.com Received: from gateway36.websitewelcome.com (HELO gateway36.websitewelcome.com) (192.185.199.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 May 2018 18:47:01 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway36.websitewelcome.com (Postfix) with ESMTP id F230C400DD1AE for ; Fri, 4 May 2018 13:46:59 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id EfjPfjsA35CKDEfjPfGAHL; Fri, 04 May 2018 13:46:59 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:40052 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fEfjP-002hm5-Nt; Fri, 04 May 2018 13:46:59 -0500 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 9/9] Add -Wimplicit-fallthrough References: <20180421183056.29292-1-tom@tromey.com> <20180421183056.29292-10-tom@tromey.com> <06cfb165-df62-7541-9e12-d5226f07078f@redhat.com> Date: Fri, 04 May 2018 18:47:00 -0000 In-Reply-To: <06cfb165-df62-7541-9e12-d5226f07078f@redhat.com> (Pedro Alves's message of "Fri, 4 May 2018 19:34:32 +0100") Message-ID: <87bmdv5kd9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fEfjP-002hm5-Nt X-Source-Sender: 97-122-176-117.hlrn.qwest.net (bapiya) [97.122.176.117]:40052 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-05/txt/msg00131.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 04/21/2018 07:30 PM, Tom Tromey wrote: >> This adds -Wimplicit-fallthrough to the set of default warnings. >> >> ../ChangeLog >> 2018-04-21 Tom Tromey >> >> * configure: Rebuild. >> * warning.m4 (AM_GDB_WARNINGS): Add -Wimplicit-fallthrough. >> >> ChangeLog >> 2018-04-21 Tom Tromey >> >> * configure: Rebuild. Pedro> Did you change your script to generate the ChangeLog's? Pedro> The paths in "../ChangeLog" and "ChangeLog" above look like Pedro> relative to gdb/gdbserver/, while I'd expect to see Pedro> gdb/ChangeLog and gdb/gdbserver/ChangeLog instead. Pedro> (Same throughout the series, but this one stood out.) I didn't change anything, so I guess there is some bug I never noticed before. I will try to find it. Thanks. Tom