From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4933 invoked by alias); 7 Jan 2014 18:43:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4923 invoked by uid 89); 7 Jan 2014 18:43:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 07 Jan 2014 18:43:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s07Ihne6024749 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Jan 2014 13:43:50 -0500 Received: from barimba (ovpn-113-85.phx2.redhat.com [10.3.113.85]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s07IhmK8003174 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 7 Jan 2014 13:43:49 -0500 From: Tom Tromey To: Michael Eager Cc: "gdb-patches\@sourceware.org" Subject: Re: [PATCH] Fix check for ICC incomplete struct types References: <52CC3790.4030702@eagerm.com> Date: Tue, 07 Jan 2014 18:43:00 -0000 In-Reply-To: <52CC3790.4030702@eagerm.com> (Michael Eager's message of "Tue, 07 Jan 2014 09:21:20 -0800") Message-ID: <87bnznhbtn.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-01/txt/msg00157.txt.bz2 >>>>> "Michael" == Michael Eager writes: Michael> GDB contains code in read_structure_type() which is supposed Michael> to check for incorrect DWARF generated by ICC for an incomplete Michael> structure type. The code is incomplete, in that it doesn't Michael> check for length == 0, and it doesn't set the STUB flag. Thanks. Michael> - if (producer_is_icc (cu)) Michael> + if (producer_is_icc (cu) && (TYPE_LENGTH (type) == 0)) Michael> { Michael> /* ICC does not output the required DW_AT_declaration Michael> on incomplete types, but gives them a size of zero. */ Michael> + TYPE_STUB (type) = 1; Michael> } Michael> else Michael> TYPE_STUB_SUPPORTED (type) = 1; It seems to me that TYPE_STUB_SUPPORTED should be set unconditionally (and, btw, eww, what a big hack TYPE_STUB_SUPPORTED is). Without the TYPE_STUB_SUPPORTED setting, TYPE_IS_OPAQUE does not honor TYPE_STUB. Then the icc check moved to the next stanza, say like: TYPE_STUB_SUPPORTED (type) = 1; if (die_is_declaration (die, cu)) TYPE_STUB (type) = 1; else if (producer_is_icc (cu) && TYPE_LENGTH (type) == 0) { /* ICC does not output the required DW_AT_declaration on incomplete types, but gives them a size of zero. */ TYPE_STUB (type) = 1; } else if (attr == NULL && die->child == NULL && producer_is_realview (cu->producer)) /* RealView does not output the required DW_AT_declaration on incomplete types. */ TYPE_STUB (type) = 1; What do you think of this? Tom