From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 3/7] Use ui_out_emit_tuple in more places
Date: Sat, 09 Sep 2017 18:32:00 -0000 [thread overview]
Message-ID: <87ca116d1d533e670303699afa0240d4@polymtl.ca> (raw)
In-Reply-To: <20170909153540.15008-4-tom@tromey.com>
On 2017-09-09 17:35, Tom Tromey wrote:
> diff --git a/gdb/mi/mi-main.c b/gdb/mi/mi-main.c
> index c485544..ca66a77 100644
> --- a/gdb/mi/mi-main.c
> +++ b/gdb/mi/mi-main.c
> @@ -2873,36 +2873,32 @@ mi_cmd_trace_frame_collected (const char
> *command, char **argv, int argc)
>
> for (i = 0; VEC_iterate (mem_range_s, available_memory, i, r);
> i++)
> {
> - struct cleanup *cleanup_child;
> - gdb_byte *data;
> struct gdbarch *gdbarch = target_gdbarch ();
>
> - cleanup_child = make_cleanup_ui_out_tuple_begin_end (uiout, NULL);
> + ui_out_emit_tuple tuple_emitter (uiout, NULL);
>
> uiout->field_core_addr ("address", gdbarch, r->start);
> uiout->field_int ("length", r->length);
>
> - data = (gdb_byte *) xmalloc (r->length);
> - make_cleanup (xfree, data);
> + gdb::byte_vector data (r->length);
>
> if (memory_contents)
> {
> - if (target_read_memory (r->start, data, r->length) == 0)
> + if (target_read_memory (r->start, data.data (), r->length) == 0)
> {
> int m;
> - char *data_str, *p;
> + char *p;
>
> - data_str = (char *) xmalloc (r->length * 2 + 1);
> - make_cleanup (xfree, data_str);
> + gdb::unique_xmalloc_ptr<char> data_str
> + ((char *) xmalloc (r->length * 2 + 1));
>
> - for (m = 0, p = data_str; m < r->length; ++m, p += 2)
> + for (m = 0, p = data_str.get (); m < r->length; ++m, p += 2)
> sprintf (p, "%02x", data[m]);
> - uiout->field_string ("contents", data_str);
> + uiout->field_string ("contents", data_str.get ());
Can this conversion to hex be replaced with a call to bin2hex (the
version that returns an std::string) ?
Otherwise, LGTM.
Simon
next prev parent reply other threads:[~2017-09-09 18:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-09 15:35 [RFA 0/7] more ui-out cleanup removal Tom Tromey
2017-09-09 15:35 ` [RFA 1/7] Use ui_out_emit_table and ui_out_emit_list in print_thread_info_1 Tom Tromey
2017-09-09 17:47 ` Simon Marchi
2017-09-09 18:36 ` Tom Tromey
2017-09-09 19:20 ` Matt Rice
2017-09-09 15:35 ` [RFA 6/7] Remove make_cleanup_ui_out_redirect_pop Tom Tromey
2017-09-09 18:49 ` Simon Marchi
2017-09-09 15:35 ` [RFA 5/7] Use ui_out_emit_list in more places Tom Tromey
2017-09-09 18:43 ` Simon Marchi
2017-09-09 15:35 ` [RFA 3/7] Use ui_out_emit_tuple " Tom Tromey
2017-09-09 18:32 ` Simon Marchi [this message]
2017-09-09 19:32 ` Tom Tromey
2017-09-09 15:35 ` [RFA 4/7] Use ui_out_emit_tuple in disasm.c Tom Tromey
2017-09-09 18:35 ` Simon Marchi
2017-10-12 15:37 ` Simon Marchi
2017-10-12 16:06 ` Simon Marchi
2017-10-12 16:11 ` Tom Tromey
2017-10-12 21:07 ` Tom Tromey
2017-10-13 16:13 ` Tom Tromey
2017-10-16 22:37 ` Simon Marchi
2017-10-16 22:59 ` Tom Tromey
2017-09-09 15:46 ` [RFA 7/7] Use ui_out_emit_list and ui_out_emit_tuple with gdb::optional Tom Tromey
2017-09-09 18:51 ` Simon Marchi
2017-09-09 15:46 ` [RFA 2/7] Remove make_cleanup_ui_out_table_begin_end Tom Tromey
2017-09-09 16:02 ` Tom Tromey
2017-09-09 18:22 ` Simon Marchi
2017-09-09 19:44 ` [RFA 0/7] more ui-out cleanup removal Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ca116d1d533e670303699afa0240d4@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).