From: Pedro Alves <pedro@palves.net>
To: Andrew Burgess <andrew.burgess@embecosm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCHv5] gdb: prevent an assertion when computing the frame_id for an inline frame
Date: Mon, 23 Aug 2021 11:26:49 +0100 [thread overview]
Message-ID: <87ce1eab-aba1-7282-97cd-89233e3d7f54@palves.net> (raw)
In-Reply-To: <20210823094159.GC2581@embecosm.com>
Hi Andrew,
Sorry I hadn't responded yet. I was out on vacation a few weeks ago, and thought I would be able to
get to this once I got back, but I got immediately pulled to a tight internal deadline instead. FWIW, I've
been very frustrated about failing to reply to you. I should be able to take a look this week, though.
On 2021-08-23 10:41 a.m., Andrew Burgess wrote:
> Ping!
>
> Simon, what are your thoughts on this approach? From what I recall of
> our discussion on IRC your concerns with my original patch were that
> after my change the function implementation no longer matched with the
> function name, this made GDB's internal APIs confusing and
> inconsistent.
>
> With this patch I've tried to avoid this by renaming the functions to
> hopefully make the API clearer.
>
> I'm just guessing, but I suspect it was the use of exceptions that
> Pedro wasn't happy with, so maybe if you're happy with this latest
> patch we could merge this change, given Pedro already approved the
> pre-exception patch.
I don't recall the discussion with Simon, but yes, use custom exceptions
for this doesn't sound great to me. Let me take a better look.
next prev parent reply other threads:[~2021-08-23 10:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 20:57 [PATCH 0/5] Fix for an assertion when unwinding with inline frames Andrew Burgess
2021-05-29 20:57 ` [PATCH 1/5] gdb/python: handle saving user registers in a frame unwinder Andrew Burgess
2021-06-07 14:50 ` Tom Tromey
2021-06-07 16:10 ` Andrew Burgess
2021-06-07 20:38 ` Tom Tromey
2021-06-07 17:07 ` Lancelot SIX
2021-06-07 17:20 ` Simon Marchi
2021-06-07 18:01 ` Lancelot SIX
2021-06-07 18:09 ` Simon Marchi
2021-06-07 20:12 ` Andrew Burgess
2021-06-21 19:41 ` Andrew Burgess
2021-05-29 20:57 ` [PATCH 2/5] gdb/python: move PyLong_From* calls into py-utils.c Andrew Burgess
2021-06-07 14:53 ` Tom Tromey
2021-06-21 19:42 ` Andrew Burgess
2021-05-29 20:57 ` [PATCH 3/5] gdb/python: add PendingFrame.level and Frame.level methods Andrew Burgess
2021-05-30 5:55 ` Eli Zaretskii
2021-05-30 18:34 ` Andrew Burgess
2021-05-30 18:54 ` Eli Zaretskii
2021-06-07 14:57 ` Tom Tromey
2021-06-21 19:42 ` Andrew Burgess
2021-05-29 20:57 ` [PATCH 4/5] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-05-29 20:57 ` [PATCH 5/5] gdb: remove VALUE_FRAME_ID Andrew Burgess
2021-06-21 19:46 ` [PATCHv2 0/2] Fix for an assertion when unwinding with inline frames Andrew Burgess
2021-06-21 19:46 ` [PATCHv2 1/2] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-07-05 11:39 ` Pedro Alves
2021-07-05 14:14 ` Simon Marchi
2021-06-21 19:46 ` [PATCHv2 2/2] gdb: remove VALUE_FRAME_ID Andrew Burgess
2021-06-29 17:53 ` Simon Marchi
2021-06-30 15:18 ` Andrew Burgess
2021-07-05 14:22 ` Simon Marchi
2021-07-20 9:10 ` [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames Andrew Burgess
2021-07-20 9:10 ` [PATCHv3 1/2] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-07-20 9:10 ` [PATCHv3 2/2] gdb: remove VALUE_FRAME_ID Andrew Burgess
2021-07-20 21:59 ` [PATCHv3 0/2] Fix for an assertion when unwinding with inline frames Simon Marchi
2021-07-26 11:11 ` Andrew Burgess
2021-07-26 13:57 ` Simon Marchi
2021-07-27 10:06 ` Andrew Burgess
2021-07-27 10:10 ` [PATCHv4] gdb: prevent an assertion when computing the frame_id for an inline frame Andrew Burgess
2021-08-09 15:41 ` [PATCHv5] " Andrew Burgess
2021-08-23 9:41 ` Andrew Burgess
2021-08-23 10:26 ` Pedro Alves [this message]
2021-08-23 12:31 ` Andrew Burgess
2021-09-20 10:04 ` Andrew Burgess
2021-09-20 12:24 ` Pedro Alves
2021-09-21 13:52 ` Andrew Burgess
2021-09-21 13:54 ` [PATCHv6] " Andrew Burgess
2021-09-22 14:14 ` Simon Marchi
2021-09-22 16:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ce1eab-aba1-7282-97cd-89233e3d7f54@palves.net \
--to=pedro@palves.net \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).