From: Tom Tromey <tom@tromey.com>
To: Johan Sternerup <johan.sternerup@gmail.com>
Cc: gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH v3 0/3] DAP: Handle "stepOut" request in outermost frame
Date: Tue, 04 Jun 2024 08:01:47 -0600 [thread overview]
Message-ID: <87cyowq01g.fsf@tromey.com> (raw)
In-Reply-To: <20240601161632.232516-1-johan.sternerup@gmail.com> (Johan Sternerup's message of "Sat, 1 Jun 2024 18:16:29 +0200")
>>>>> "Johan" == Johan Sternerup <johan.sternerup@gmail.com> writes:
Johan> Add support for stepping commands to be run as background tasks so that
Johan> immediate errors can be caught and reported back to the client.
Johan> Specifically, make use of this for "stepOut" so that in the case of trying to
Johan> send a "stepOut" request in the outermost frame we can now report the error back
Johan> to the client. Then the client knows that it should still expect the inferior to
Johan> be stopped and should not wait for a stoppedEvent.
Hi. Thanks for the patches. These look good to me.
Approved-By: Tom Tromey <tom@tromey.com>
If you think you'll be writing more gdb patches, email me and I can get
you set up with write-after-approval access, and you can push your own
series. However if you would prefer, let me know and I can check these
in for you.
thanks,
Tom
next prev parent reply other threads:[~2024-06-04 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-01 16:16 Johan Sternerup
2024-06-01 16:16 ` [PATCH 1/3] DAP: Allow for deferring stop events from gdb thread Johan Sternerup
2024-06-01 16:16 ` [PATCH 2/3] DAP: Allow gdb exception in exec_and_log to propagate Johan Sternerup
2024-06-01 16:16 ` [PATCH 3/3] DAP: Handle "stepOut" request in outermost frame Johan Sternerup
2024-06-04 14:01 ` Tom Tromey [this message]
2024-06-05 13:54 ` [PATCH v3 0/3] " Johan Sternerup
2024-06-05 16:01 ` Tom Tromey
2024-06-06 17:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyowq01g.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=johan.sternerup@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).