From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x232.google.com (mail-oi1-x232.google.com [IPv6:2607:f8b0:4864:20::232]) by sourceware.org (Postfix) with ESMTPS id 38DA23858D35 for ; Tue, 30 Apr 2024 02:07:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38DA23858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 38DA23858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::232 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714442861; cv=none; b=Q6oqZBYW84oxIcNBz1jyOFnUbCqnhNpFkjGNslML3xlNT3F/10PJtQYIc8FRKkWc2UKQ93xBh1u9b4i8H0xjIP48J9gMyNNwyKPIO4PcW8+BnnWjEexMK5DtIWCrDAc9wIgLzha9UJ3WE4wPejspOAGRLRJTagFH7l6L0PPt1vs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714442861; c=relaxed/simple; bh=shv7bgkw/nMO0X4mr0G7p6pYHBXovnGBgCtvyXH9Fvk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=QpB32U1BcJ6rnWSx0m7fxwdJdXiS9iJFL3qZcxcb7yKjFezLX6xFJW1fy6PX1DiM9cmNfwabuUJxZxuB00nCQto+SIrpVJTqtKBNRmqs6GG+basuWHb4hCIA3T08H385lEXQ0gqmsKOOyl+CpmTUXWSKritoFg8bvsNg8aWH4wU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x232.google.com with SMTP id 5614622812f47-3c844b6edbbso3095256b6e.1 for ; Mon, 29 Apr 2024 19:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1714442859; x=1715047659; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xd5p1SoS9dKeLg6hhv97SL3wMMnK/nXDx5qW6FWuE3k=; b=P4AuY5V0vIAqBg+felmrycA+LCawWYbr/w+KHBk4dGMzbxWIlvaXKdJI3XUl1Vt1I6 PsX7XsOtENqkz31Uo5EdJNxFNJOqQ2/YPPYH6l8zFPaNRPm3FnuE8LDc7HUxtjOfJfQ/ 4kWi5bOx5s4dIcxJsIt30OjpyHM8v1WUCHyubdMand1bU/6gFdovNWZvUFwnWtuPaY1+ xqmlXl9YiG2GBzYMZo6sdWtBgENDpIbEpOqhx/yfODPfGvB07btJFGER0nN1xmypss91 wBfHm4lFK2dtwHN3BzGj6AQxBcx4Zfr7JUxTmoqrsg0KJcXoh5gshPJ451exj1NsJF2e k36Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714442859; x=1715047659; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xd5p1SoS9dKeLg6hhv97SL3wMMnK/nXDx5qW6FWuE3k=; b=pHKfbWgXQltWpAiSwWtWGem4S1+wwP4tnMF6DgYaO/7YBUx6u6VIr38MuVUNDp/ksz pQJWRpuWl5SCakzq8t6lQTx8wc2aCLo/Kx4+1BhL6UFITYRXnk/r5kHn/DoxU494RYv3 Yd6RUmqMm7KMJZKaK0vKkE55OPfwd96WBaZmL1xUxUxyoH55S8CS3Mgh3Xdhjlu+EsjK fSH94iRml0gj91N/dw2ivvzSBBPNSSN15tJl4/LRUnZCDfnh0pY8IiaJGoRX9F/JDbx6 BKXtwdAzEpmrr0Mw5vlS79i5RXpWNfu2GAxBegOM2vwCNAQwgh4CA3VhKF23ixP8258E wjJg== X-Gm-Message-State: AOJu0YwDuAXc+kUq21v+mMt2bbpHbiDItayYiuhx10DsPepbfx5VAOCv 9TgwUP9ArZXStK0aO4R2w7nYyL5ypGtuaeAYgPw2sVVdP5ymgCUGtmKI2OZcZG1T2FjMSGvg9jL 5 X-Google-Smtp-Source: AGHT+IFyqBQ8D3xihfCnL6D6Io6i8G/HCSFUp3f5j9jl09I1NqKLDDIHWFnfeKHVghftQXkGs28JWw== X-Received: by 2002:a05:6808:d53:b0:3c7:2fb0:516 with SMTP id w19-20020a0568080d5300b003c72fb00516mr15679662oik.39.1714442859226; Mon, 29 Apr 2024 19:07:39 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:3d56:74b5:22f4:1590]) by smtp.gmail.com with ESMTPSA id le7-20020a056a004fc700b006e567c81d14sm19943382pfb.43.2024.04.29.19.07.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 19:07:38 -0700 (PDT) From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches@sourceware.org, Bernd Edlinger Subject: Re: [PATCH] gdb/testsuite: Fix libc_has_debug_info when there's no libc In-Reply-To: <87wmokf5bt.fsf@tromey.com> (Tom Tromey's message of "Fri, 26 Apr 2024 10:37:26 -0600") References: <20240426025251.1679310-1-thiago.bauermann@linaro.org> <87wmokf5bt.fsf@tromey.com> User-Agent: mu4e 1.12.4; emacs 29.3 Date: Mon, 29 Apr 2024 23:07:36 -0300 Message-ID: <87cyq7zjpz.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Tom, Tom Tromey writes: >>>>>> "Thiago" == Thiago Jung Bauermann writes: > > Thiago> Fix by: > > Thiago> - always defining libc_has_debug_info and message with a default > Thiago> value, > Thiago> - adding a pattern for the case where there's no libc.so in the > Thiago> inferior, and > Thiago> - removing the default pattern, which doesn't serve a purpose anymore. > > Thiago> Also, remove a couple of verbose messages which aren't really useful > Thiago> because they're redundant with the $message variable. > > Thanks. This looks reasonable to me. > Approved-By: Tom Tromey Thank you. And thank you Bernd for testing the patch. Though Pedro raised concerns about libc_has_debug_info: https://inbox.sourceware.org/gdb-patches/b0409c48-7f9c-4430-91d9-dc7cfa86a9c7@palves.net/ So I just sent a new patch which is an alternative to this one: https://inbox.sourceware.org/gdb-patches/20240430015325.89780-1-thiago.bauermann@linaro.org/ which restores the original behaviour and also fixes Bernd's reported Tcl error. -- Thiago