From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id 3D08E3858D32 for ; Mon, 15 Apr 2024 16:22:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D08E3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D08E3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713198131; cv=none; b=nOEDftsbJpzoqIuwaJ0pjVpQG4F8AwL7iIGv1PS3+pPwSEqztC8lsT4IgIzY1JVr/OWy025I+x2GBHIPcYmM2tBq5ulIp9GDrEwHxtF3hgOEd5ifBEaQYLHZLfvTmjLG15p13yjn3hgRXUvzWHw54BuqIpZr+NM0kjbRRtvM73o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713198131; c=relaxed/simple; bh=WujIBBM5m7QTUDnDXOuUcas6Xk/L3RGEBxDIZHOUnI8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=C6b6WiFTFPUeeA7fhsO5c7ROjndG931dkzmjLc1ZvLFV4FH4HJQYpcOvrKJgbt6wC/iMZv29eoDSoXE7EDJQbbG8Fzu6rvcHSWeH+c29wm7sL36Cc+e+HYNTm5dnfy4Kxz8w2q5Nl7M+OfidqMeJ7iBa8JWZ2fN34nGXPKT1uAg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5001a.ext.cloudfilter.net ([10.0.29.139]) by cmsmtp with ESMTPS id wDI8rfawZQr4SwP5srjBYY; Mon, 15 Apr 2024 16:22:08 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id wP5srthPKCaXowP5srDQWd; Mon, 15 Apr 2024 16:22:08 +0000 X-Authority-Analysis: v=2.4 cv=deBL3mXe c=1 sm=1 tr=0 ts=661d5430 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=7d_E57ReAAAA:8 a=1ALMIJDq-ZCE3LTIJhEA:9 a=jhqOcbufqs7Y1TYCrUUU:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=mSRoZ7jPoGuvNHMATcaQPXhBt7hRWC+0pPoEph4CJpk=; b=EvK9CuW8YYIipfYB1S5mMYBwzk g65+jts8CBqgWxhubZG0Vm1vkGEoprM2yjTIUzR6+YIHA1vwRh6qSmcftV207It/S3E2tEx/OHzAK MgM408iAowXW/uXMQNKqCHeL9; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:55154 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rwP5r-003fDG-2e; Mon, 15 Apr 2024 10:22:07 -0600 From: Tom Tromey To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension References: <20240412175200.829114-1-simon.marchi@efficios.com> X-Attribution: Tom Date: Mon, 15 Apr 2024 10:22:07 -0600 In-Reply-To: <20240412175200.829114-1-simon.marchi@efficios.com> (Simon Marchi's message of "Fri, 12 Apr 2024 13:51:54 -0400") Message-ID: <87cyqq38b4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rwP5r-003fDG-2e X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:55154 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfH/U1TzO1Mktnhw4969bpI9rlAcFfL4UhHRGlLpMTynV3rbAUpNCWr9G/MYiOb4TCBENOhaqIR6kAsbDZYwN7DpK3babZcqN63wkv8jLGy0lB9XTePIu VwR9V6dReWg28Y9u2JPW+KWG1xB6tTqEwoAApCyzxyXGaU+S/cR/NYQXfOGyWVCA2zn6XEIGCYiqJJqzXWkeHGLeWjDGxZkuPeo= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> When building with clang 18, I see: Simon> CXX aarch64-linux-tdep.o Simon> /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension] Simon> 1299 | gdb_byte za_zeroed[za_bytes]; Simon> | ^~~~~~~~ Simon> /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1299:26: note: read of non-const variable 'za_bytes' is not allowed in a constant expression Simon> /home/smarchi/src/binutils-gdb/gdb/aarch64-linux-tdep.c:1282:10: note: declared here Simon> 1282 | size_t za_bytes = std::pow (sve_vl_from_vg (svg), 2); Simon> | ^ Simon> Since we are using VLAs right now, that warning doesn't make sense for Simon> us. add `-Wno-vla-cxx-extension` to the list of warning flags we try to Simon> enable. If we ever choose to disallow VLAs, we can remove that flag. I wonder if we should instead remove the use of VLAs. Is it just the one spot? Tom